Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-2896] Improve HdfsSensor() #3746

Closed

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Aug 13, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:
  1. Make documentation clearer (format for ignored_ext should be extensions like 'py' rather than '.py')
  2. Ensure upper/lower case would not affect the usage of ignored_ext feagure.
  3. Improve test coverage by adding tests for methods filter_for_ignored_ext() and filter_for_filesize()

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@XD-DENG XD-DENG force-pushed the hdfs_sensor.filter_for_ignored_ext branch 5 times, most recently from 9ee9741 to 1fa8de3 Compare August 14, 2018 23:41
1. Make documentation clearer (format for
  `ignored_ext` should be extensions like
   ''py rather than '.py').
2. Ensure upper/lower case would not affect
   the usage of `ignored_ext` feagure.
3. Add tests for methods
   filter_for_ignored_ext()
   and filter_for_filesize().
@XD-DENG XD-DENG force-pushed the hdfs_sensor.filter_for_ignored_ext branch from 1fa8de3 to f87923a Compare August 15, 2018 01:16
@XD-DENG
Copy link
Member Author

XD-DENG commented Aug 15, 2018

1 out of 9 tests failed due to

ERROR: InvocationError for command '/home/travis/build/apache/incubator-airflow/scripts/ci/setup_env.sh' (exited with code 1)

/home/travis/.travis_cache//cdh/hadoop.tar.gz: Cannot open: Permission denied

Not sure whether it's a Travis-CI issue.

@bolkedebruin
Copy link
Contributor

Hdfs is being refactored in #3560 and I think this is then already outdated

@XD-DENG
Copy link
Member Author

XD-DENG commented Aug 15, 2018

Thanks @bolkedebruin . Didn't know the refactoring going on. Will close this PR.

@XD-DENG XD-DENG closed this Aug 15, 2018
@XD-DENG XD-DENG deleted the hdfs_sensor.filter_for_ignored_ext branch August 20, 2018 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants