Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3010] added support for date format to postgres_to_gcs_operator #3850

Conversation

rlkelly
Copy link

@rlkelly rlkelly commented Sep 5, 2018

Make sure you have checked all steps below.

Jira

Description

  • [ X ] Here are some details about my PR, including screenshots of any UI changes:

    I just changed it so the Date datatype would be acknowledged in write and read.

Tests

  • [ X ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Currently the schema functionality is largely untested and this would be a larger undertaking if we wanted to create better testing for serialization.

Commits

  • [ X ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • [ X ] In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@Fokko
Copy link
Contributor

Fokko commented Sep 5, 2018

Thanks @dgingrich for the PR. Do you think it is possible to test this?

Recently we've moved to Docker for the testing. Therefore we have a Postgres instance available in a linked container.

@dgingrich
Copy link

@Fokko I didn't submit the PR or the bug, I think you want @rlkelly

@rlkelly
Copy link
Author

rlkelly commented Sep 5, 2018

I could improve the test coverage on this if this is something you'd be interested in using

@SamWildmo
Copy link

I could use this. Any chance this will be in 1.10.1?

@Fokko
Copy link
Contributor

Fokko commented Oct 15, 2018

@SamWildmo
Copy link

@rlkelly will you add the test?

@stale
Copy link

stale bot commented Dec 31, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 31, 2018
@stale stale bot closed this Jan 10, 2019
@OmerJog
Copy link
Contributor

OmerJog commented Mar 26, 2019

@rlkelly any chance to revisit this? I use this fix manually by having a custom operator. I would be nice if this can be in the official airflow release

@Fokko
Copy link
Contributor

Fokko commented Mar 29, 2019

@OmerJog You can also cherry-pick @rlkelly's work and continue with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants