docs: Remove quotes from domain in Google Oauth #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noqcks
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4226 +/- ##
=======================================
Coverage 77.81% 77.81%
=======================================
Files 201 201
Lines 16348 16348
=======================================
Hits 12721 12721
Misses 3627 3627Continue to review full report at Codecov.
|
|
Good one, thanks @noqcks |
tmiller-msft
pushed a commit
to cse-airflow/incubator-airflow
that referenced
this pull request
Nov 27, 2018
elizabethhalper
pushed a commit
to cse-airflow/incubator-airflow
that referenced
this pull request
Dec 7, 2018
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
wmorris75
pushed a commit
to modmed/incubator-airflow
that referenced
this pull request
Jul 29, 2019
potiuk
pushed a commit
that referenced
this pull request
Feb 12, 2020
Related SO: https://stackoverflow.com/a/52528091/10638329 (cherry picked from commit 44df8a1)
kaxil
pushed a commit
that referenced
this pull request
Feb 21, 2020
Related SO: https://stackoverflow.com/a/52528091/10638329 (cherry picked from commit 44df8a1)
kaxil
pushed a commit
that referenced
this pull request
Mar 19, 2020
Related SO: https://stackoverflow.com/a/52528091/10638329 (cherry picked from commit 44df8a1)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2020
Related SO: https://stackoverflow.com/a/52528091/10638329 (cherry picked from commit 44df8a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation example that uses quotes around the
domainin Google Oauth authentication currently doesn't work.Using
domainwith quotes around domains results in "You don't seem to have access. Please contact your administrator" when logging in.Removing the quotes results in the ability to login with the
domain.Also mentioned in this Stackoverflow: https://stackoverflow.com/a/52528091/10638329