[AIRFLOW-3384] Allow higher versions of Sqlalchemy and Jinja2 #4227
Conversation
|
Ok, that should do it. Master is broken atm, I guess that I'll pass that final test config when master builds again. |
|
@jlricon can youy please execute this on your own Travis? Opening and closing for just the sake of biuilding is costing us money. If travis fails please check why it fails and fix cases accordingly. Obviously have your PR squashed and cleanup as well, that makes intregration a lot cleaner. Thanks! |
jlricon
force-pushed
the
allow-higher-sqla-jinja
branch
from
3033560
to
c4ce3fa
Compare
|
@bolkedebruin Yes, sorry for that. It was a dockerhub issue it seems. All tests pass now in my local Travis, so I'm pushing again, hopefully last time. |
|
For some reason it is not passing here even though it passed locally, it's not something in the changes I've introduced. Other contributors have also complained about Travis recently. The first time it was failing a lot of tests, now it is only one. I am going to close-open once now, and if it doesn't work I will look into it every 2 days to avoid abusing this repo's Travis. |
Codecov Report
@@ Coverage Diff @@
## master #4227 +/- ##
==========================================
- Coverage 77.82% 77.82% -0.01%
==========================================
Files 201 201
Lines 16366 16360 -6
==========================================
- Hits 12737 12732 -5
+ Misses 3629 3628 -1
Continue to review full report at Codecov.
|
* [AIRFLOW-3384] Allow higher versions of SQLAlchemy and Jinja2
…#4227) * [AIRFLOW-3384] Allow higher versions of SQLAlchemy and Jinja2
…#4227) * [AIRFLOW-3384] Allow higher versions of SQLAlchemy and Jinja2
|
Hello guys, I am not sure if it's the right place to ask it, but do you think if these upgrades will be included in the next release please ? Thanks ! |
|
@ncrocfer Yes this will be available in the next release :) - 1.10.2 |
* [AIRFLOW-3384] Allow higher versions of SQLAlchemy and Jinja2
…#4227) * [AIRFLOW-3384] Allow higher versions of SQLAlchemy and Jinja2
* [AIRFLOW-3384] Allow higher versions of SQLAlchemy and Jinja2
…#4227) * [AIRFLOW-3384] Allow higher versions of SQLAlchemy and Jinja2
`piptools.compile` is failing for ETL after [1], because `amundsendatabuilder` depends on `sqlalchemy>1.2` and airflow depends on `sqlalchemy<=1.2`. This change was already made upstream [2], so I think it should be OK. The changelog looks pretty innocuous [3]. [1] amundsen-io/amundsendatabuilder@b480d00 [2] apache#4227 [3] https://docs.sqlalchemy.org/en/13/changelog/migration_13.html
`piptools.compile` is failing for ETL after [1], because `amundsendatabuilder` depends on `sqlalchemy>1.2` and airflow depends on `sqlalchemy<=1.2`. This change was already made upstream [2], so I think it should be OK. The changelog looks pretty innocuous [3]. [1] amundsen-io/amundsendatabuilder@b480d00 [2] apache#4227 [3] https://docs.sqlalchemy.org/en/13/changelog/migration_13.html
Make sure you have checked all steps below.
Jira
Description
Tests