-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIRFLOW-3573 - Remove DagStat table #4378
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4378 +/- ##
==========================================
- Coverage 78.16% 78.14% -0.03%
==========================================
Files 204 204
Lines 16530 16434 -96
==========================================
- Hits 12921 12842 -79
+ Misses 3609 3592 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks @ffinfo
* Remove DagStat usage * Remove tests * Remove dag_stat table from db * Removed dagstat class * Revert change * Fixing test
Can you please resolve an error that was in the PR but because of broken Travis it wasn't detected:
Please fix it in the new PR. |
@ffinfo PTAL |
@Fokko I think meanwhile this is already fixed on master |
* Remove DagStat usage * Remove tests * Remove dag_stat table from db * Removed dagstat class * Revert change * Fixing test
* Remove DagStat usage * Remove tests * Remove dag_stat table from db * Removed dagstat class * Revert change * Fixing test
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR apache#4378, back in Dec 2018 apache#4378
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
This is a clean-up/housekeeping change. Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018 apache/airflow#4378 GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
Make sure you have checked all steps below.
Jira
Description
The table DagStat can be removed after AIRFLOW-3561
Tests
No need, only removing code
Commits
Documentation
No need, just removing unused code.
Code Quality
flake8