Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIRFLOW-3573 - Remove DagStat table #4378

Merged
merged 6 commits into from
Dec 30, 2018
Merged

Conversation

ffinfo
Copy link
Contributor

@ffinfo ffinfo commented Dec 27, 2018

Make sure you have checked all steps below.

Jira

Description

The table DagStat can be removed after AIRFLOW-3561

Tests

No need, only removing code

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

No need, just removing unused code.

Code Quality

  • Passes flake8

@codecov-io
Copy link

codecov-io commented Dec 27, 2018

Codecov Report

Merging #4378 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4378      +/-   ##
==========================================
- Coverage   78.16%   78.14%   -0.03%     
==========================================
  Files         204      204              
  Lines       16530    16434      -96     
==========================================
- Hits        12921    12842      -79     
+ Misses       3609     3592      -17
Impacted Files Coverage Δ
airflow/models/__init__.py 92.57% <ø> (-0.24%) ⬇️
airflow/jobs.py 77.44% <ø> (+0.02%) ⬆️
airflow/www_rbac/views.py 72.78% <ø> (+0.19%) ⬆️
airflow/www/views.py 69.47% <100%> (+0.15%) ⬆️
airflow/bin/cli.py 65.06% <100%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc078a...41e7ac0. Read the comment docs.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @ffinfo

@Fokko Fokko merged commit 53e7074 into apache:master Dec 30, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
* Remove DagStat usage

* Remove tests

* Remove dag_stat table from db

* Removed dagstat class

* Revert change

* Fixing test
@kaxil
Copy link
Member

kaxil commented Jan 5, 2019

Can you please resolve an error that was in the PR but because of broken Travis it wasn't detected:

======================================================================
3) FAIL: test_delete_dag_dag_still_in_dagbag (tests.api.common.experimental.test_delete_dag.TestDeleteDAGCatchError)
----------------------------------------------------------------------
   Traceback (most recent call last):
    tests/api/common/experimental/test_delete_dag.py line 61 in test_delete_dag_dag_still_in_dagbag
      delete_dag(self.dag_id)
   AssertionError: DagFileExists not raised

Please fix it in the new PR.

@Fokko
Copy link
Contributor

Fokko commented Jan 7, 2019

@ffinfo PTAL

@ffinfo
Copy link
Contributor Author

ffinfo commented Jan 10, 2019

@Fokko I think meanwhile this is already fixed on master

ashb pushed a commit to ashb/airflow that referenced this pull request Apr 1, 2019
* Remove DagStat usage

* Remove tests

* Remove dag_stat table from db

* Removed dagstat class

* Revert change

* Fixing test
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
* Remove DagStat usage

* Remove tests

* Remove dag_stat table from db

* Removed dagstat class

* Revert change

* Fixing test
XD-DENG added a commit to XD-DENG/airflow that referenced this pull request Nov 26, 2020
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR apache#4378, back in Dec 2018
apache#4378
XD-DENG added a commit that referenced this pull request Nov 27, 2020
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
#4378
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2021
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 27, 2021
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 10, 2022
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 4, 2022
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 7, 2022
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 9, 2022
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
This is a clean-up/housekeeping change.

Usage of 'dirty_ids' is no longer applicable since PR #4378, back in Dec 2018
apache/airflow#4378

GitOrigin-RevId: 6e9c110e8b66ee5357e205969752fde07fa32916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants