-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-3576] Remove unnecessray arg 'root' for /delete in dag.html #4380
Conversation
@Noremac201 may you advise on this PR as you authored the original commit (#3531)? Kindly let me know if I have misunderstood or missed anything in your implementation. Thanks! |
'root' is not used anywhere in `delete` method in either www/views.py or www_rbac/views.py. Having it in url_for("airflow.delete", dag_id=dag.dag_id, root=root) in dag.html is meaningless.
3082886
to
1e87643
Compare
1 test (out of 9) failed due to transient error. |
Lgtm👍 |
have restarted the test |
Codecov Report
@@ Coverage Diff @@
## master #4380 +/- ##
==========================================
- Coverage 78.16% 78.16% -0.01%
==========================================
Files 204 204
Lines 16530 16530
==========================================
- Hits 12921 12920 -1
- Misses 3609 3610 +1
Continue to review full report at Codecov.
|
Hi @kaxil , a gentle ping. The tests have passed. |
LGTM |
…pache#4380) 'root' is not used anywhere in `delete` method in either www/views.py or www_rbac/views.py. Having it in url_for("airflow.delete", dag_id=dag.dag_id, root=root) in dag.html is meaningless.
…pache#4380) 'root' is not used anywhere in `delete` method in either www/views.py or www_rbac/views.py. Having it in url_for("airflow.delete", dag_id=dag.dag_id, root=root) in dag.html is meaningless.
…pache#4380) 'root' is not used anywhere in `delete` method in either www/views.py or www_rbac/views.py. Having it in url_for("airflow.delete", dag_id=dag.dag_id, root=root) in dag.html is meaningless.
Jira
https://issues.apache.org/jira/browse/AIRFLOW-3576
Description
In
airflow/www/templates/airflow/dag.html
orairflow/www_rbac/templates/airflow/dag.html
, in line<a href="{{ url_for("airflow.delete", dag_id=dag.dag_id, root=root) }}"
,root
is not necessary, given it's not used anywhere in the'/delete'
method in eitherairflow/www/views.py
orairflow/www_rbac/views.py
.Please correct me if I'm incorrect about this or missed anything.