Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License breaks helm chart #590

Closed
mortenbirkelund opened this issue Oct 27, 2023 · 1 comment · Fixed by #591
Closed

License breaks helm chart #590

mortenbirkelund opened this issue Oct 27, 2023 · 1 comment · Fixed by #591
Labels
bug Something isn't working

Comments

@mortenbirkelund
Copy link

Describe the bug
After adding the license header in 3d2187d
the helm chart doesn work anymore, because the apiversion of the serviceaccount is being mistakenly seen as a comment.

Removing the license header, and then the chart works again. This only happens in the service account, because it is the only one that is deployed conditional depending on the values.

https://github.com/apache/incubator-answer/blob/main/charts/templates/serviceaccount.yaml

See an explanation here:
argoproj/argo-helm#507 (comment)

To Reproduce
Steps to reproduce the behavior:

  1. Go to the charts directory
  2. run helm template .

Expected behavior
The serviceaccount rendered correctly
image

Screenshots
The serviceaccount is missing the apiversion, because it is seen as a comment
image

Platform (please complete the following information):

  • Device: [e.g. Desktop, Mobile]
  • OS: [e.g. macOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
@mortenbirkelund mortenbirkelund added the bug Something isn't working label Oct 27, 2023
@mortenbirkelund
Copy link
Author

Explanation can be seen here
helm/helm#4191

Can be solved by changing
{{- if .Values.serviceAccount.create -}}

to
{{ if .Values.serviceAccount.create -}}

sy-records added a commit to lufei/incubator-answer that referenced this issue Oct 28, 2023
fix apache/incubator-answer\apache#590
tisonkun pushed a commit that referenced this issue Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant