This repository has been archived by the owner on Jul 17, 2018. It is now read-only.
CLI commands for parser #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tliron
force-pushed
the
ARIATOSCA-22-cli-commands-for-parser
branch
2 times, most recently
from
c079c54
to
bd4cf91
Compare
dankilman
suggested changes
Nov 17, 2016
| @@ -295,3 +294,68 @@ def _load_workflow_handler(handler_path): | |||
| except AttributeError: | |||
| # todo: exception handler | |||
| raise | |||
|
|
|||
| from ..parser.consumption import (ConsumptionContext, ConsumerChain, Read, Validate, Model, Types, Inputs, Instance) | |||
There was a problem hiding this comment.
why are the imports here and not at the top?
| self.logger.info('blueprint parsed successfully') | ||
| deployment_plan = prepare_deployment_plan(plan=plan.copy(), inputs=inputs) | ||
| return plan, deployment_plan | ||
| #plan = parse_from_path(blueprint_path) |
There was a problem hiding this comment.
can we implement this functionality using the new parser? if not, let's remove the commented lines
| @@ -44,6 +46,7 @@ def __init__(self, *args, **kwargs): | |||
| self.commands = { | |||
| 'init': InitCommand.with_logger(base_logger=self.logger), | |||
| 'execute': ExecuteCommand.with_logger(base_logger=self.logger), | |||
| 'parse': ParseCommand.with_logger(base_logger=self.logger), | |||
There was a problem hiding this comment.
why did you decide to leave out spec?
| ==== | ||
|
|
||
| See http://ariatosca.org/ | ||
| [ARIA](http://ariatosca.org/) is a minimal TOSCA orchestrator, as well as a platform for building | ||
| TOSCA-based products. Its features can be accessed via a well-documented Python API, as well as a |
There was a problem hiding this comment.
no language-agnostic RESTful API for now
| pip install tox | ||
| tox | ||
|
|
||
| To build the documentation: |
There was a problem hiding this comment.
we currently have no make file (or docs), so probably best to remove this line
|
Also, please amend to commit message to include |
|
Please see this document regarding commit message guidelines: |
tliron
force-pushed
the
ARIATOSCA-22-cli-commands-for-parser
branch
3 times, most recently
from
76acef4
to
4ca7579
Compare
tliron
force-pushed
the
ARIATOSCA-22-cli-commands-for-parser
branch
from
4ca7579
to
3323819
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some fixed to TOSCA extension.