This repository has been archived by the owner on Jul 17, 2018. It is now read-only.
ARIA-42-Generic-ctx-serialization-mechanism #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmrlv
changed the title
asfgit
force-pushed
the
ARIA-42-Generic-ctx-serialization-mechanism
branch
7 times, most recently
from
77165a4
to
4c5126e
Compare
mxmrlv
commented
Feb 8, 2017
aria/storage/core.py
Outdated
| def __init__(self, api_cls, api_kwargs=None, items=(), **kwargs): | ||
| def __init__(self, | ||
| api_cls, | ||
| items=(), |
There was a problem hiding this comment.
add api_kwargs and move init, init_kwargs to ModelStorage (and rename init to session_initiator)
aria/storage/sql_mapi.py
Outdated
|
|
||
| from sqlalchemy import create_engine |
aria/storage/sql_mapi.py
Outdated
| path=os.path.join(base_dir, filename)) | ||
| engine_kwargs = {} | ||
| else: | ||
| uri = 'sqlite:///:memory:' |
There was a problem hiding this comment.
remove in memory option to tests only
tests/mock/context.py
Outdated
|
|
||
| deployment_id = create_simple_topology_two_nodes(model_storage) | ||
| model_storage = aria.application_model_storage( |
There was a problem hiding this comment.
be consistent with initiator passing
|
|
||
| def __init__(self, *args, **kwargs): | ||
| def __init__(self, *args, **kwargs): # pylint: disable=super-init-not-called |
There was a problem hiding this comment.
add serialize function
|
|
||
| def __init__(self, *args, **kwargs): | ||
| def __init__(self, *args, **kwargs): # pylint: disable=super-init-not-called |
|
Can one of the admins verify this patch? |
ran-z
reviewed
Feb 8, 2017
aria/storage/core.py
Outdated
| @@ -66,10 +67,10 @@ def __init__(self, | |||
| self.registered = {} | |||
| self._initiator = initiator | |||
| self._initiator_kwargs = initiator_kwargs or {} | |||
| self._api_kwargs = api_kwargs or {} | |||
| self._additional_api_kwargs = {} | |||
There was a problem hiding this comment.
add information about initiator interface
ran-z
suggested changes
Feb 8, 2017
aria/storage/core.py
Outdated
| @@ -66,10 +67,10 @@ def __init__(self, | |||
| self.registered = {} | |||
| self._initiator = initiator | |||
| self._initiator_kwargs = initiator_kwargs or {} | |||
| self._api_kwargs = api_kwargs or {} | |||
| self._additional_api_kwargs = {} | |||
ran-z
reviewed
Feb 8, 2017
| @@ -65,3 +65,14 @@ def release_sqlite_storage(storage): | |||
| session.close() | |||
| for engine in set(mapi._engine for mapi in mapis): | |||
asfgit
force-pushed
the
ARIA-42-Generic-ctx-serialization-mechanism
branch
from
3436987
to
6311e45
Compare
asfgit
force-pushed
the
ARIA-42-Generic-ctx-serialization-mechanism
branch
from
6311e45
to
1498ad3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.