Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-162] Check for closed windows early #105

Closed
wants to merge 2 commits into from
Closed

[BEAM-162] Check for closed windows early #105

wants to merge 2 commits into from

Conversation

mshields822
Copy link
Contributor

Rather than squash speculation on the bug I'll post this early.

Will do unit test and try to get more randomization into NexMark Q11 so we can tease out these rare failures before our customers do.

@kennknowles
Copy link
Member

R: @kennknowles

@kennknowles
Copy link
Member

LGTM. Waiting for tests then merging.

@mshields822
Copy link
Contributor Author

PTAL

@mshields822
Copy link
Contributor Author

Can we merge? Then I'll back-port to DataflowSDK.

@mshields822
Copy link
Contributor Author

R=@bjchambers
In case you want to cherry pick this and Repeatably trigger bug fixes.

@kennknowles
Copy link
Member

LGTM, merging

@kennknowles
Copy link
Member

But we do need to revisit this, semantically.

@asfgit asfgit closed this in fba1259 Apr 1, 2016
davorbonaci added a commit to GoogleCloudPlatform/DataflowJavaSDK that referenced this pull request Apr 4, 2016
@davorbonaci
Merge pull request #175 from kennknowles/backport-105
1a457b3 
Backport apache/beam#105
iemejia referenced this pull request in iemejia/beam Jan 12, 2018
@davorbonaci
This closes #105
afd1f26
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
apache#105 Add (failing) proof-of-concept test
56a1c90
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
apache#105 Rework StateFactory API; Stabilize JoinState implementation
b18b9f4
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
apache#105 Do not read entire disk storage into memory
1447b02
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
apache#105 Provide an experimental "early emitting" join state implem…
22e8042 
…entation
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
apache#105 Simplify closing spilling file
aaa00af
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
apache#105 Document some more experiment dangers
e8f3d3b
mareksimunek pushed a commit to mareksimunek/beam that referenced this pull request May 9, 2018
apache#105 Add reference to future solution
b78c1a5
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
apache#105 Add (failing) proof-of-concept test
671dacc
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
apache#105 Rework StateFactory API; Stabilize JoinState implementation
2bd7a89
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
apache#105 Do not read entire disk storage into memory
8d77a61
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
apache#105 Provide an experimental "early emitting" join state implem…
bfba706 
…entation
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
apache#105 Simplify closing spilling file
f949503
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
apache#105 Document some more experiment dangers
0f1ecd7
dmvk pushed a commit to dmvk/beam that referenced this pull request May 15, 2018
apache#105 Add reference to future solution
449b593
mareksimunek pushed a commit to seznam/beam that referenced this pull request Jul 9, 2018
@mareksimunek
apache#105 Add (failing) proof-of-concept test
64370d5
mareksimunek pushed a commit to seznam/beam that referenced this pull request Jul 9, 2018
@mareksimunek
apache#105 Rework StateFactory API; Stabilize JoinState implementation
e03c5a4
mareksimunek pushed a commit to seznam/beam that referenced this pull request Jul 9, 2018
@mareksimunek
apache#105 Do not read entire disk storage into memory
c5d15f8
mareksimunek pushed a commit to seznam/beam that referenced this pull request Jul 9, 2018
@mareksimunek
apache#105 Provide an experimental "early emitting" join state implem…
b700808 
…entation
mareksimunek pushed a commit to seznam/beam that referenced this pull request Jul 9, 2018
@mareksimunek
apache#105 Simplify closing spilling file
274e9e4
mareksimunek pushed a commit to seznam/beam that referenced this pull request Jul 9, 2018
@mareksimunek
apache#105 Document some more experiment dangers
3136805
mareksimunek pushed a commit to seznam/beam that referenced this pull request Jul 9, 2018
@mareksimunek
apache#105 Add reference to future solution
1ff6461
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
apache#105 Add (failing) proof-of-concept test
c5b2f7e
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
apache#105 Rework StateFactory API; Stabilize JoinState implementation
4b49302
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
apache#105 Do not read entire disk storage into memory
390cc4b
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
apache#105 Provide an experimental "early emitting" join state implem…
81d6b50 
…entation
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
apache#105 Simplify closing spilling file
7f77686
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
apache#105 Document some more experiment dangers
b023ee8
dmvk pushed a commit to seznam/beam that referenced this pull request Aug 17, 2018
apache#105 Add reference to future solution
b3a29d2
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
apache#105 Add (failing) proof-of-concept test
fa2bcfd
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
apache#105 Rework StateFactory API; Stabilize JoinState implementation
4cebcec
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
apache#105 Do not read entire disk storage into memory
f5d9cb8
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
apache#105 Provide an experimental "early emitting" join state implem…
bb3f3c0 
…entation
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
apache#105 Simplify closing spilling file
e75738c
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
apache#105 Document some more experiment dangers
b9c46a8
dmvk pushed a commit to seznam/beam that referenced this pull request Oct 5, 2018
apache#105 Add reference to future solution
f5691f4
alnzng pushed a commit to alnzng/beam that referenced this pull request Aug 25, 2023
@xinyuiscool
Invoke RunnerPipelineOptionsFactory by checking stack trace (apache#105)
661324b
pl04351820 pushed a commit to pl04351820/beam that referenced this pull request Dec 20, 2023
@crwilcox
test: add imports into test_collections systest (apache#88) (apache#105)
cb8606a 
* test: add imports into test_collections systest

* Revert "test: add imports into test_collections systest"

This reverts commit beaefa51c695ef27fab77e9145bfa861e0f8bcea.

* move the test into a separate case

Co-authored-by: Gurov Ilya <ilya.faer@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mshields822 @kennknowles