[BEAM-551] Add NestedValueProvider #1146
Conversation
|
|
||
| /** | ||
| * An interface that provides a translator for a {@link NestedValueProvider} | ||
| * to produce a value from a deferred {@link ValueProvider}. |
There was a problem hiding this comment.
we should pick some consistent logic about these names. Are they "deferrable" or "runtime" or something else?
There was a problem hiding this comment.
ack, should use runtime
|
|
||
| @Nullable | ||
| private final ValueProvider<X> value; | ||
| private final DeferrableTranslator<T, X> translator; |
There was a problem hiding this comment.
Can we just use SerializableFunction for this?
There was a problem hiding this comment.
Um, yes, indeed.
|
|
||
| NestedValueProvider(@Nullable ValueProvider<X> value, DeferrableTranslator<T, X> translator) { | ||
| this.value = value; | ||
| this.translator = translator; |
There was a problem hiding this comment.
checkNotNull the non-nullable value.
There was a problem hiding this comment.
(Maybe I'm missing something, but why is the VP allowed to be null?)
|
|
||
| /** | ||
| * An interface that provides a translator for a {@link NestedValueProvider} | ||
| * to produce a value from a deferred {@link ValueProvider}. |
There was a problem hiding this comment.
ack, should use runtime
|
|
||
| @Nullable | ||
| private final ValueProvider<X> value; | ||
| private final DeferrableTranslator<T, X> translator; |
There was a problem hiding this comment.
Um, yes, indeed.
|
|
||
| NestedValueProvider(@Nullable ValueProvider<X> value, DeferrableTranslator<T, X> translator) { | ||
| this.value = value; | ||
| this.translator = translator; |
| * {@link NestedValueProvider} is an implementation of {@link ValueProvider} that | ||
| * allows for wrapping another {@link ValueProvider} object. | ||
| */ | ||
| public static class NestedValueProvider<T, X> implements ValueProvider<T>, Serializable { |
There was a problem hiding this comment.
ValueProvider.java:100:3: Redundant 'public' modifier. [RedundantModifier]
checkstyle :/
|
Manually fixed the checkstyle issue and merged. |
Wrote this up based on some nascent thoughts, and looking ahead to PubsubIO, which uses a bunch of wrapper classes instead of String. This allows us to nicely turn those into VP instead of deferring all the translation code into the caller, which would be gross.
R: @dhalperi