[BEAM-194] Add Java 8 examples archetype including mobile gaming example, with generator script #1344

kennknowles · 2016-11-10T22:58:28Z

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
If this contribution is large, please file an Apache
Individual Contributor License Agreement.

kennknowles · 2016-11-10T23:18:10Z

kennknowles · 2016-11-10T23:19:08Z

Caveat: it is a bit of a copy/paste/modify job. The deps from the other archetype satisfied the gaming example, which means they need to be pruned.

kennknowles · 2016-11-11T04:09:25Z

Travis failures are all IWYU flake in starter archetype.

davorbonaci

I'd like to take a peek whether we can do something that reduces the amount of code duplication.

With your (awesome) scripts, perhaps we can generate the archetype source at build time, as opposed to that code being checked in.

I'd be happy to help!

davorbonaci · 2016-11-13T22:55:45Z

sdks/java/maven-archetypes/java8-examples/pom.xml

@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="UTF-8"?>


directory rename: java8-examples -> examples-java8?

davorbonaci · 2016-11-13T22:56:09Z

sdks/java/maven-archetypes/java8-examples/pom.xml

+    <relativePath>../pom.xml</relativePath>
+  </parent>
+
+  <artifactId>beam-sdks-java-maven-archetypes-java8-examples</artifactId>


examples-java8

davorbonaci · 2016-11-13T22:56:39Z

sdks/java/maven-archetypes/java8-examples/pom.xml

+  </parent>
+
+  <artifactId>beam-sdks-java-maven-archetypes-java8-examples</artifactId>
+  <name>Apache Beam :: SDKs :: Java :: Maven Archetypes :: Java 8 Examples</name>


Examples - Java 8

davorbonaci · 2016-11-13T22:57:20Z

sdks/java/maven-archetypes/java8-examples/pom.xml

+      </plugins>
+    </pluginManagement>
+  </build>
+  <dependencies>


empty line above

davorbonaci · 2016-11-13T22:59:24Z

sdks/java/maven-archetypes/java8-examples/src/main/resources/archetype-resources/pom.xml

+
+    <dependency>
+      <groupId>com.google.api-client</groupId>
+      <artifactId>google-api-client</artifactId>


can you double check where some of the dependencies are coming from? Starting with this one, most of the following are suspicious.

Confirmed that these are all dependencies of examples-java8 or examples-java, which are both included in this archetype.

davorbonaci · 2016-11-13T23:02:19Z

.../java8-examples/src/main/resources/archetype-resources/src/main/java/DebuggingWordCount.java

@@ -0,0 +1,164 @@
+/*


This is the third copy of the wordcount pipelines; we should try to do something better.

Yes, it makes sense to not check these in. I don't know off the top of my head the best way to do that. Filed BEAM-1005.

davorbonaci · 2016-11-13T23:03:32Z

...types/java8-examples/src/main/resources/archetype-resources/src/main/java/complete/README.md

@@ -0,0 +1,62 @@
+<!--


Is it worth excluding the README?

davorbonaci · 2016-11-13T23:03:51Z

.../java8-examples/src/main/resources/archetype-resources/src/main/java/complete/game/README.md

@@ -0,0 +1,131 @@
+<!--


kennknowles · 2016-11-18T00:08:58Z

I have now also configured things so the content is generated, and removed sources from both archetypes. Unfortunately the way the configuration is inherited means that the exec plugin tries to execute again and fails, in some slightly curious way. One option is to move the execution to the parent, but that seems wrong. The other option is to wait until I have a few more minutes to dig into the behavior and see how to squash it.

davorbonaci

I think this is a great improvement!

davorbonaci · 2016-11-18T17:23:12Z

.gitignore

@@ -6,6 +6,10 @@
 target/
 bin/

+# Ignore generated archetypes


I believe convention is that this goes to ${project.build.directory}/generated-sources/, so it should not be necessary due to target/ exclusion.

I've spent a couple minutes looking for documentation on this, and I don't think archetype:create-from-project has a way to support putting things in generated-sources to be instantiated to the user's src directory.

davorbonaci · 2016-11-18T17:26:13Z

sdks/java/maven-archetypes/examples/src/main/resources/archetype-resources/pom.xml

+
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-dependency-plugin</artifactId>


This doesn't belong here, right? Global plugin management?

davorbonaci · 2016-11-18T17:27:59Z

sdks/java/maven-archetypes/pom.xml

@@ -34,6 +34,7 @@
  <modules>
    <module>starter</module>
    <module>examples</module>
+    <module>examples-java8</module>


Only on supported platforms?

kennknowles · 2016-11-18T18:00:36Z

Both archetypes are now autogenerated and I've had local success with verification. I have included a fix of some very old and presumably obsolete configuration that was breaking things. Jenkins had a transient failure but I have kicked it.

kennknowles · 2016-11-30T02:58:25Z

It is worth noting that actually building the archetypes like this involves unix scripting so it not MS Windows friendly. We either need to check in the generated code or disable these processes on MS Windows.

This archetype module is automatically generated during the build process, and its dependencies and tests verified.

kennknowles · 2016-12-02T22:41:45Z

I have updated the archetype parent to only run the unix-only builds on unix platforms. For now, at least this will make enthusiasts able to build the project on any platform, and users are not affected anyhow. If a Windows OS contributor would care to try to make this portable to Windows, that is welcome.

asfbot · 2016-12-03T01:49:06Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/5484/
--none--

davorbonaci · 2016-12-03T05:19:59Z

This looks pretty awesome right now. High-level LGTM. Will take a closer look, but won't have anything more than low-level comments.

davorbonaci · 2016-12-04T00:11:39Z

LGTM

Merging, since this is a clear improvement. However, java8 archetype also needs profiles to be able to run them, and possibly other fixups. Let's address them in a followup pull request.

kennknowles force-pushed the moar-examples branch 3 times, most recently from afca6ce to 18a33eb Compare November 10, 2016 23:17

davorbonaci requested changes Nov 13, 2016

View reviewed changes

kennknowles force-pushed the moar-examples branch 2 times, most recently from 852d2a8 to 1619179 Compare November 18, 2016 00:07

kennknowles force-pushed the moar-examples branch from 1619179 to 6e4c93c Compare November 18, 2016 16:53

davorbonaci reviewed Nov 18, 2016

View reviewed changes

kennknowles force-pushed the moar-examples branch 3 times, most recently from 2e591f7 to e0fcb31 Compare November 18, 2016 17:59

kennknowles mentioned this pull request Nov 22, 2016

Quickstart: suggest using nightly build temporarily apache/beam-site#89

Closed

kennknowles force-pushed the moar-examples branch 3 times, most recently from 497db40 to d6aa36a Compare November 23, 2016 21:49

kennknowles added 3 commits December 2, 2016 14:35

Remove global default execution of exec-maven-plugin

d9c3f53

Create java8-examples archetype module

cd30fbe

This archetype module is automatically generated during the build process, and its dependencies and tests verified.

Autogenerate examples archetype during build

d93b183

kennknowles force-pushed the moar-examples branch from d6aa36a to d93b183 Compare December 2, 2016 22:40

asfgit closed this in c22b97d Dec 4, 2016

kennknowles deleted the moar-examples branch December 6, 2016 05:23

MarcoRob mentioned this pull request Oct 13, 2021

[BEAM-8218] WIP, PulsarIO, looking forward for initial feedback #15572

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BEAM-194] Add Java 8 examples archetype including mobile gaming example, with generator script #1344

[BEAM-194] Add Java 8 examples archetype including mobile gaming example, with generator script #1344

kennknowles commented Nov 10, 2016 •

edited

kennknowles commented Nov 10, 2016

kennknowles commented Nov 10, 2016

kennknowles commented Nov 11, 2016

davorbonaci left a comment

davorbonaci Nov 13, 2016

kennknowles Nov 17, 2016

davorbonaci Nov 13, 2016

kennknowles Nov 17, 2016

davorbonaci Nov 13, 2016

kennknowles Nov 17, 2016

davorbonaci Nov 13, 2016

kennknowles Nov 17, 2016

davorbonaci Nov 13, 2016

kennknowles Nov 17, 2016

davorbonaci Nov 13, 2016

kennknowles Nov 17, 2016

davorbonaci Nov 13, 2016

kennknowles Nov 17, 2016

davorbonaci Nov 13, 2016

kennknowles Nov 17, 2016

kennknowles commented Nov 18, 2016

davorbonaci left a comment

davorbonaci Nov 18, 2016

kennknowles Nov 23, 2016

davorbonaci Nov 18, 2016

kennknowles Nov 23, 2016

davorbonaci Nov 18, 2016

kennknowles Nov 23, 2016

kennknowles commented Nov 18, 2016

kennknowles commented Nov 30, 2016

kennknowles commented Dec 2, 2016

asfbot commented Dec 3, 2016

davorbonaci commented Dec 3, 2016

davorbonaci commented Dec 4, 2016 •

edited

[BEAM-194] Add Java 8 examples archetype including mobile gaming example, with generator script #1344

[BEAM-194] Add Java 8 examples archetype including mobile gaming example, with generator script #1344

Conversation

kennknowles commented Nov 10, 2016 • edited

kennknowles commented Nov 10, 2016

kennknowles commented Nov 10, 2016

kennknowles commented Nov 11, 2016

davorbonaci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kennknowles commented Nov 18, 2016

davorbonaci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kennknowles commented Nov 18, 2016

kennknowles commented Nov 30, 2016

kennknowles commented Dec 2, 2016

asfbot commented Dec 3, 2016

davorbonaci commented Dec 3, 2016

davorbonaci commented Dec 4, 2016 • edited

kennknowles commented Nov 10, 2016 •

edited

davorbonaci commented Dec 4, 2016 •

edited