Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-983] runners/spark/translation/streaming/utils/TestPipelineOptions.java missing Apache license header. #1362

Closed
wants to merge 1 commit into from

Conversation

amitsela
Copy link
Member

@amitsela amitsela commented Nov 15, 2016

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@amitsela
Copy link
Member Author

amitsela commented Nov 15, 2016

@davorbonaci Jenkins is slacking around here, not doing it's job 😉
Would you know something about it ?

@davorbonaci
Copy link
Member

@amitsela -- not sure, nothing has changed regarding this particular job recently. I think it's probably a temporary outage around asfbot. I'd probably wait a bit and see what happens.

The precommit is running jobs for other PRs as we speak: https://builds.apache.org/job/beam_PreCommit_MavenVerify/

@amitsela
Copy link
Member Author

amitsela commented Nov 15, 2016

@davorbonaci I don't see a PreCommit running for this PR..
And now it's building something that was committed 7 days ago: #1319

@amitsela amitsela changed the title [BEAM-983] add missing license. [BEAM-983] runners/spark/translation/streaming/utils/TestPipelineOptions.java missing Apache license header. Nov 15, 2016
@davorbonaci
Copy link
Member

(it was committed 7 days ago, but it might have been pushed just now)

@kennknowles
Copy link
Member

kennknowles commented Nov 15, 2016

FWIW I think our configuration is probably broken. The command mvn rat:check fails on master even after the rollback, even after running git clean -d -f -x.

It is quite hard to tell, as there is no documentation for the format of the report (that I know of) and it lists 26k lines of content that is explicitly ignored.

@amitsela amitsela closed this Nov 15, 2016
@amitsela amitsela deleted the BEAM-983 branch November 15, 2016 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants