[BEAM-362] Move ActiveWindowSet and implementations to runners-core #1592
Conversation
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 2beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-examples-java: 2
--none-- |
|
R: @amitsela this will require me to get LGTM and then bump Dataflow to be ready for the change |
|
Failures are |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-examples-java: 1--none-- |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-examples-java: 1--none-- |
|
Looks like Dataflow still didn't "bump" ? |
|
Yea, I didn't bump yet. Just retested to clear out the other errors. It'll happen soon... |
kennknowles
force-pushed
the
ActiveWindowSet
branch
from
9a71e6e
to
064a845
Compare
kennknowles
force-pushed
the
ActiveWindowSet
branch
from
064a845
to
bcf0298
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
It seems that the Jenkins build from when this had conflicts actually did run and did succeed. I don't understand how it successfully merged - if it pulled by PR # instead of by hash and got the conflict-resolved version then that success would presumably be reflected on the commit status. Very confusing. |
|
Refer to this link for build results (access rights to CI server needed): |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
In service, ultimately, of clearing all state internals out of the SDK.