Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1149] Cherry pick some fixes to release-0.4.0 #1619

Merged
merged 2 commits into from
Dec 14, 2016

Conversation

kennknowles
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

This fixes the remaining failures in BEAM-1149. I have confirmed mvn clean verify and the Spark runner's local runnable-on-service tests.

@davorbonaci
Copy link
Member

LGTM for cherrypick.

R: @jkff for code review

@kennknowles
Copy link
Member Author

CC: @jbonofre as release manager - these fix BEAM-1149 crashers in all batch-style runners (Spark and Dataflow) that are caught by the new test @jkff added.

@jkff
Copy link
Contributor

jkff commented Dec 14, 2016

LGTM

@asfgit asfgit merged commit d9f24b8 into apache:release-0.4.0-incubating Dec 14, 2016
asfgit pushed a commit that referenced this pull request Dec 14, 2016
@asfbot
Copy link

asfbot commented Dec 14, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/5920/
--none--

@kennknowles kennknowles deleted the cherry-picks branch December 15, 2016 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants