[BEAM-210] Test that empty final panes are not produced. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2016 11:34
Add a test that we get an empty `ON_TIME` pane, and don't get the empty final pane when using accumulation mode with the only if non-empty `ClosingBehavior`.
|
LGTM |
| // Trigger with 2 elements | ||
| WindowMatchers.isSingleWindowedValue(containsInAnyOrder(1, 2), 1, 0, 10), | ||
| // Trigger for the empty on time pane. | ||
| WindowMatchers.isSingleWindowedValue(containsInAnyOrder(1, 2), 9, 0, 10))); |
There was a problem hiding this comment.
You said you couldn't repro the problem in the JIRA ticket, but this test seems to confirm exactly the WAI behavior.
There was a problem hiding this comment.
I was unable to repro the report of broken behavior. I was able to verify the WAI behavior.
|
LGTM, but do wait for travis as well. We have had a couple issues caught by only one or the other CI. |
|
I added a copy of this test with TRIGGER_ALWAYS. |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
Add WindowedValue#explodeWindows
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
…lied-if [euphoria-core] make sure that windowBy() can be appliedIf()
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.