Add a compatibility stub of GABWViaWindowSetDoFn #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Direct calls to `org.apache.beam.sdk.util.GroupAlsoByWindowViaWindowSetDoFn#create` failed following the rename in 892ead2. This re-introduces that method as a redirect to the new name to unbreak things while waiting for a complete fix.
|
LGTM |
|
You mean reflective calls? Obviously direct calls would be compile-time breakage. |
|
LGTM, but let's follow up and fix at the source. |
dhalperi
pushed a commit
to dhalperi/beam
that referenced
this pull request
Aug 23, 2016
* Check for existence of job before polling. Closes apache#330. In case of local runners, export job does not exists, check if job exists before polling for result. This will prevent unnecessary exceptions, polling in local mode. * Merge PR-331, and fixups. * address feedback
asfgit
pushed a commit
that referenced
this pull request
Jul 6, 2017
…s (cherry-pick to release-2.1.0)
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
) * chore: remove obsolete skip for old Python 3 versions * perf: strip proto wrappers in '_helpers.decode_{value,dict}' Closes apache#351.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Direct calls to
org.apache.beam.sdk.util.GroupAlsoByWindowViaWindowSetDoFn#createfailed following the rename in 892ead2.
This re-introduces that method as a redirect to the new name to
unbreak things while waiting for a complete fix.