Fixes issue with local short circuit (memcpy) path in the RDMA storage #8
Conversation
tier - mmaped buffers were previously indexed with wrong LBA in RdmaStorageLocalEndpoint This fixes the CRAIL-3 JIRA ticket https://issues.apache.org/jira/browse/CRAIL-3 Signed-off-by: Patrick Stuedi <pstuedi@apache.org>
| bufferMap.put(lba, OffHeapBuffer.wrap(mappedBuffer)); | ||
| lba += mappedBuffer.capacity(); | ||
| long lba = Long.parseLong(dataFile.getName()); | ||
| OffHeapBuffer offHeapBuffer = OffHeapBuffer.wrap(mmap(dataFile)); |
There was a problem hiding this comment.
@patrickstuedi can you please indent it properly :)
may be you also don't need these two explicit variables, they are just used once. But I understand for clarity it is fine.
Also - just that I understand, the file names are enumerated with proper name/offset. Because before you had lba+=mappedBuffer.capacity() logic.
Otherwise looks good to me.
There was a problem hiding this comment.
actually, the indentation was issue with my display. Sorry.
There was a problem hiding this comment.
before the hashtable index was a byte offset, now it's just an int index. We could move back to the byte offset by multiplying the lba with the capacity, and then also multiply the aligneLba with the capacity, but that's unnecessary in my mind.
There was a problem hiding this comment.
the actual problem with the previous code was that the lba was created based on the ordering provided by the Java directory iterator which of course doesn't respect the ordering of the filenames with integer based names..there no guaranteed ordering at all.
tier - mmaped buffers were previously indexed with wrong LBA in RdmaStorageLocalEndpoint This fixes the CRAIL-3 JIRA ticket https://issues.apache.org/jira/browse/CRAIL-3 Close apache#8 Signed-off-by: Patrick Stuedi <pstuedi@apache.org> Signed-off-by: Adrian Schuepbach <asq@apache.org>
tier
RdmaStorageLocalEndpoint
This fixes the CRAIL-3 JIRA ticket
https://issues.apache.org/jira/browse/CRAIL-3
Signed-off-by: Patrick Stuedi pstuedi@apache.org