refactor: add subtask register for github plugin

apache · Jun 9, 2023 · c570292 · c570292
1 parent 9e7d857
commit c570292
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/backend/plugins/github/impl/impl.go b/backend/plugins/github/impl/impl.go
@@ -43,12 +43,15 @@ var _ plugin.DataSourcePluginBlueprintV200 = (*Github)(nil)
 var _ plugin.CloseablePluginTask = (*Github)(nil)
 
 // var _ plugin.PluginSource = (*Github)(nil)
+var sortedSubtaskList []plugin.SubTaskMeta
 
 type Github struct{}
 
 func init() {
-	// check subtask meta loop when init subtask meta
-	if _, err := subtaskmeta_sorter.NewDependencySorter(tasks.SubTaskMetaList).Sort(); err != nil {
+	var err error
+	// check subtask meta loop and gen subtask list when init subtask meta
+	sortedSubtaskList, err = subtaskmeta_sorter.NewDependencySorter(tasks.SubTaskMetaList).Sort()
+	if err != nil {
 		panic(err)
 	}
 }
@@ -102,11 +105,7 @@ func (p Github) Description() string {
 }
 
 func (p Github) SubTaskMetas() []plugin.SubTaskMeta {
-	list, err := subtaskmeta_sorter.NewDependencySorter(tasks.SubTaskMetaList).Sort()
-	if err != nil {
-		panic(err)
-	}
-	return list
+	return sortedSubtaskList
 }
 
 func (p Github) PrepareTaskData(taskCtx plugin.TaskContext, options map[string]interface{}) (interface{}, errors.Error) {