-
Notifications
You must be signed in to change notification settings - Fork 499
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: add subtask register for github plugin (#5411)
* refactor: add subtask registert for github * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask meta register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: Update remote.go * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register * refactor: update subtask register * refactor: update subtask register * refactor: add subtask register * refactor: add subtask register * refactor: add subtask register
- Loading branch information
1 parent
f8ad90e
commit cc39ef2
Showing
63 changed files
with
897 additions
and
193 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
/* | ||
Licensed to the Apache Software Foundation (ASF) under one or more | ||
contributor license agreements. See the NOTICE file distributed with | ||
this work for additional information regarding copyright ownership. | ||
The ASF licenses this file to You under the Apache License, Version 2.0 | ||
(the "License"); you may not use this file except in compliance with | ||
the License. You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package sorter | ||
|
||
import ( | ||
"github.com/apache/incubator-devlake/core/errors" | ||
"github.com/apache/incubator-devlake/core/plugin" | ||
) | ||
|
||
type TableSorter struct { | ||
metas []*plugin.SubTaskMeta | ||
} | ||
|
||
func NewTableSorter(metas []*plugin.SubTaskMeta) SubTaskMetaSorter { | ||
return &TableSorter{metas: metas} | ||
} | ||
|
||
func (d *TableSorter) Sort() ([]plugin.SubTaskMeta, errors.Error) { | ||
return tableTopologicalSort(d.metas) | ||
} | ||
|
||
func tableTopologicalSort(metas []*plugin.SubTaskMeta) ([]plugin.SubTaskMeta, errors.Error) { | ||
constructedMetas := constructDependenciesByTable(metas) | ||
return dependenciesTopologicalSort(constructedMetas) | ||
} | ||
|
||
func constructDependenciesByTable(metas []*plugin.SubTaskMeta) []*plugin.SubTaskMeta { | ||
// construct map by metas and their produced tables, the key is table, and value is metas | ||
tableMetasMap := make(map[string][]*plugin.SubTaskMeta) | ||
for _, item := range metas { | ||
for _, tableItem := range item.ProductTables { | ||
if value, ok := tableMetasMap[tableItem]; ok { | ||
tableMetasMap[tableItem] = append(value, item) | ||
} else { | ||
tableMetasMap[tableItem] = []*plugin.SubTaskMeta{item} | ||
} | ||
} | ||
} | ||
// construct meta dependencies by meta.TableDependencies | ||
// use noDupMap to deduplicate dependencies of meta | ||
noDupMap := make(map[*plugin.SubTaskMeta]map[*plugin.SubTaskMeta]any) | ||
for _, metaItem := range metas { | ||
// convert dependency tables to dependency metas | ||
dependenciesMap, ok := noDupMap[metaItem] | ||
if !ok { | ||
noDupMap[metaItem] = make(map[*plugin.SubTaskMeta]any) | ||
dependenciesMap = noDupMap[metaItem] | ||
} | ||
for _, tableItem := range metaItem.DependencyTables { | ||
for _, item := range tableMetasMap[tableItem] { | ||
dependenciesMap[item] = "" | ||
} | ||
} | ||
metaItem.Dependencies = keys(dependenciesMap) | ||
} | ||
return metas | ||
} | ||
|
||
func keys[T comparable](raw map[T]any) []T { | ||
list := make([]T, 0) | ||
for key := range raw { | ||
list = append(list, key) | ||
} | ||
return list | ||
} |
81 changes: 81 additions & 0 deletions
81
backend/helpers/pluginhelper/subtaskmeta/sorter/table_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
/* | ||
Licensed to the Apache Software Foundation (ASF) under one or more | ||
contributor license agreements. See the NOTICE file distributed with | ||
this work for additional information regarding copyright ownership. | ||
The ASF licenses this file to You under the Apache License, Version 2.0 | ||
(the "License"); you may not use this file except in compliance with | ||
the License. You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package sorter | ||
|
||
import ( | ||
"github.com/apache/incubator-devlake/core/errors" | ||
"github.com/apache/incubator-devlake/core/plugin" | ||
"reflect" | ||
"testing" | ||
) | ||
|
||
func Test_tableTopologicalSort(t *testing.T) { | ||
pluginA := plugin.SubTaskMeta{ | ||
Name: "A", | ||
DependencyTables: []string{}, | ||
ProductTables: []string{"_TOOL_TEST_TABLE", "_TOOL_TEST_TABLE2"}, | ||
} | ||
pluginB := plugin.SubTaskMeta{ | ||
Name: "B", | ||
DependencyTables: []string{"_TOOL_TEST_TABLE"}, | ||
ProductTables: []string{"_TOOL_TEST_TABLE2", "_TOOL_TEST_TABLE3"}, | ||
} | ||
pluginC := plugin.SubTaskMeta{ | ||
Name: "C", | ||
DependencyTables: []string{"_TOOL_TEST_TABLE"}, | ||
ProductTables: []string{"_TOOL_TEST_TABLE3"}, | ||
} | ||
pluginD := plugin.SubTaskMeta{ | ||
Name: "D", | ||
DependencyTables: []string{"_TOOL_TEST_TABLE2", "_TOOL_TEST_TABLE3"}, | ||
ProductTables: []string{"_TOOL_TEST_TABLE4"}, | ||
} | ||
|
||
type args struct { | ||
metas []*plugin.SubTaskMeta | ||
} | ||
tests := []struct { | ||
name string | ||
args args | ||
want []plugin.SubTaskMeta | ||
want1 errors.Error | ||
}{ | ||
{ | ||
name: "test sorter", | ||
args: args{[]*plugin.SubTaskMeta{&pluginA, &pluginB, &pluginC, &pluginD}}, | ||
want: []plugin.SubTaskMeta{pluginA, pluginB, pluginC, pluginD}, | ||
want1: nil, | ||
}, | ||
} | ||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
got, got1 := tableTopologicalSort(tt.args.metas) | ||
if len(got) != len(tt.want) { | ||
t.Errorf("tableTopologicalSort() got = %v, want %v", got, tt.want) | ||
} | ||
for index, item := range got { | ||
if item.Name != tt.want[index].Name { | ||
t.Errorf("tableTopologicalSort() got = %v, want %v, not equal with index = %d", got, tt.want, index) | ||
} | ||
} | ||
if !reflect.DeepEqual(got1, tt.want1) { | ||
t.Errorf("tableTopologicalSort() got1 = %v, want %v", got1, tt.want1) | ||
} | ||
}) | ||
} | ||
} |
Oops, something went wrong.