fix: error id for scope config changed (#7456)

apache · May 11, 2024 · d7807f9 · d7807f9
1 parent 5aac711
commit d7807f9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/config-ui/src/plugins/components/scope-config/index.tsx b/config-ui/src/plugins/components/scope-config/index.tsx
@@ -38,7 +38,7 @@ interface Props {
   scopeName: string;
   id?: ID;
   name?: string;
-  onSuccess?: (id?: ID, hideToast?: boolean) => void;
+  onSuccess?: (id?: ID) => void;
 }
 
 export const ScopeConfig = ({ plugin, connectionId, scopeId, scopeName, id, name, onSuccess }: Props) => {
@@ -83,13 +83,13 @@ export const ScopeConfig = ({ plugin, connectionId, scopeId, scopeName, id, name
 
     if (success) {
       handleHideDialog();
-      onSuccess?.(id, type === 'duplicate');
+      onSuccess?.(trId);
     }
   };
 
   const handleUpdate = (trId: ID) => {
     handleHideDialog();
-    onSuccess?.(id);
+    onSuccess?.(trId);
   };
 
   return (

diff --git a/config-ui/src/routes/connection/connection.tsx b/config-ui/src/routes/connection/connection.tsx
@@ -241,7 +241,7 @@ export const Connection = () => {
     }
   };
 
-  const handleScopeConfigChange = async (scopeConfigId?: ID, hideToast?: boolean) => {
+  const handleScopeConfigChange = async (scopeConfigId?: ID) => {
     if (!scopeConfigId) {
       setVersion(version + 1);
       return;
@@ -250,7 +250,7 @@ export const Connection = () => {
     const [success, res] = await operator(() => API.scopeConfig.check(plugin, scopeConfigId), { hideToast: true });
 
     if (success) {
-      if (!res.projects || hideToast) {
+      if (!res.projects) {
         setVersion(version + 1);
         return;
       }