Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][config-ui?] Issue with Incorrect URL Path Conversion in DevLake #5976

Closed
2 of 3 tasks
KelvinVenancio opened this issue Aug 29, 2023 · 4 comments · Fixed by #5987
Closed
2 of 3 tasks

[Bug][config-ui?] Issue with Incorrect URL Path Conversion in DevLake #5976

KelvinVenancio opened this issue Aug 29, 2023 · 4 comments · Fixed by #5987
Assignees
Labels
type/bug This issue is a bug

Comments

@KelvinVenancio
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

I have identified an issue within DevLake's URL handling where the character "/" for Project name is not being properly converted to "%2F" as it should be. This problem is causing DevLake to interpret a path that doesn't actually exist, leading to incorrect behavior and unexpected results.

When attempting to use a URL containing the "/" character, DevLake fails to encode it correctly as "%2F", which is the standard URL-encoded representation for a forward slash. Consequently, the application is unable to correctly interpret and route requests that involve this character in the URL path.

What do you expect to happen

I expect that when using the DevLake application Projects with "/" on the name, any occurrence of the "/" character in the URL path should be correctly encoded as "%2F" according to standard URL encoding rules. This proper encoding will enable DevLake to accurately interpret and route requests involving URLs containing the "/" character.

How to reproduce

To reproduce the issue, follow these steps:

  1. Create a new project with a "/" character in its name.
  2. Add a "Data Connections" component to the project.
  3. Click on "Edit Data Scope and Scope Config" for the added component.

The error occurs in step 3, as illustrated by the images below:

Screen Shot 2023-08-29 at 08-58-31
Screen Shot 2023-08-29 at 08-59-22
Screen Shot 2023-08-29 at 09-00-41

Upon performing these steps, you should observe the incorrect behavior where the DevLake application fails to properly handle the "/" character in the URL, leading to an error or unexpected result. This reproduction will help demonstrate the problem and assist in identifying the root cause of the issue.

Anything else

Note that in image 3 above, the access worked correctly after I corrected the URL manually by adding the code for the character "/".

Version

v0.18.0-beta7

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@KelvinVenancio KelvinVenancio added the type/bug This issue is a bug label Aug 29, 2023
@Startrekzky
Copy link
Contributor

I think this is a bug.

@mintsweet
Copy link
Member

Hi, @KelvinVenancio. Thank you for your report.
But I didn't catch the error from your screenshot. Can you provide the error screenshot?

@KelvinVenancio
Copy link
Author

KelvinVenancio commented Aug 30, 2023 via email

@mintsweet
Copy link
Member

Hi, @KelvinVenancio, sorry for missing the error image. I will fix it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug This issue is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants