Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question][CI/CD] How can we stop auto collection of CI/CD metrics? #7375

Open
thiDucTran opened this issue Apr 25, 2024 · 11 comments
Open

[Question][CI/CD] How can we stop auto collection of CI/CD metrics? #7375

thiDucTran opened this issue Apr 25, 2024 · 11 comments
Labels
severity/p2 This bug doesn’t affect the functionality or isn’t evident type/question This issue is a question
Milestone

Comments

@thiDucTran
Copy link

thiDucTran commented Apr 25, 2024

Question

Hi, what is the correct config to use if we do not want to automatically collect deployment/builds/etc data? Referencing https://devlake.apache.org/docs/DataModels/DevLakeDomainLayerSchema#data-models, I have tried not choosing CI/CD for my data scope config...but deployment data is still being collected. Using v1beta5 with azure devops GO connection

FYI: i asked this also in slack. see https://devlake-io.slack.com/archives/C03APJ20VM4/p1714025708040129

Screenshots

image
image

@thiDucTran thiDucTran added the type/question This issue is a question label Apr 25, 2024
@klesh
Copy link
Contributor

klesh commented Apr 26, 2024

@thiDucTran Hi, by design, the previously collected data of selected entities won't be deleted but simply skipping those related subtasks, please check if the collectApiBuilds subtask is showing in the pipeline plan JSON for the plugin
image

@thiDucTran
Copy link
Author

i dont see collectApiBuilds

    [
      {
        "plugin": "azuredevops_go",
        "subtasks": [
          "collectAccounts",
          "collectApiPullRequests",
          "convertRepo",
          "extractAccounts",
          "convertAccounts",
          "extractApiPullRequests",
          "collectApiPullRequestCommits",
          "convertApiBuilds",
          "convertApiPullRequests",
          "convertPrLabels",
          "extractApiPullRequestCommits",
          "convertApiPullRequestsCommits",
          "convertApiTimelineRecords"
        ],

@thiDucTran
Copy link
Author

thiDucTran commented Apr 26, 2024

idk if this is an issue..and if it is a separate issue that needs its own github issue. but sharing it again from the slack thread

whenever I do a new pipeline run..i see that it changed updated_at for all of the pipeline runs to the same time (see before and after picture)

although, what is this data used for..i do not think it is used to calculate DORA? because when I go to the DORA - Deployment frequency dashboard...it's empty (as expected)...so there seems to be a difference between pipeline runs that you see in Azure DevOps dashboard versus deployments that you would see in DORA dashboards_

image
image

@klesh
Copy link
Contributor

klesh commented Apr 28, 2024

Weird, why there is a convertApiBuilds in the subtasks list.
It looks like a bug indeed, would you like to file it in a separate issue and we will look into it?

@abeizn
Copy link
Contributor

abeizn commented Apr 28, 2024

@thiDucTran Already effective in v1.0.0-beta6

@thiDucTran
Copy link
Author

thiDucTran commented Apr 29, 2024

issue is not resolved for me in v1.0.0-beta6 ? CI/CD metrics still gets collected... I even deleted the project...purge scope's data...re-created project..made sure CI/CD is not in my scope config...colleted data..and I still see ci/cd metrics in Azure DevOps dashboard

        "plugin": "azuredevops_go",
        "subtasks": [
          "collectAccounts",
          "collectApiPullRequests",
          "convertRepo",
          "extractAccounts",
          "convertAccounts",
          "extractApiPullRequests",
          "collectApiPullRequestCommits",
          "convertApiPullRequests",
          "convertPrLabels",
          "extractApiPullRequestCommits",
          "convertApiPullRequestsCommits",
          "convertApiTimelineRecords"
        ],

i think part of the issue is that mysql data is not really removed? I still see records like this after deleting the project, clear data scope historical data, and even removing the data scope...

SELECT
  *
FROM 
  cicd_pipelines

image

@klesh klesh reopened this Apr 29, 2024
@abeizn
Copy link
Contributor

abeizn commented Apr 29, 2024

@thiDucTran What is the value of your environment variable ENABLE_SUBTASKS_BY_DEFAULT?

@klesh
Copy link
Contributor

klesh commented Apr 29, 2024

@thiDucTran That is weird, I don't see any related subtasks in the list. Can you check the raw tables and see if the data gets purged?

@thiDucTran
Copy link
Author

i edited my previous comment....seems data is not purged

@klesh klesh added the severity/p2 This bug doesn’t affect the functionality or isn’t evident label Apr 29, 2024
@klesh
Copy link
Contributor

klesh commented Apr 29, 2024

To be investigated.

@thiDucTran
Copy link
Author

thiDucTran commented May 29, 2024

Hi, would I need to create another issue for the table cicd_deployment_commits ? I have deleted the project and data scope..but data of deleted project is still there in cicd_deployment_commits ..using 1.0.0-beta9

edit: also seeing unpurged data in table cicd_deployments ..i mean there could be other tables with unpurged data as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/p2 This bug doesn’t affect the functionality or isn’t evident type/question This issue is a question
Projects
None yet
Development

No branches or pull requests

3 participants