fix: reduce the entities collected by default #7366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klesh
reviewed
Apr 26, 2024
| for s := range subtaskMetas { | ||
| compareName := pluginName + ":" + subtaskMetas[s].Name | ||
| if stringInSlice(compareName, enableSubtasksList) { | ||
| subtaskMetas[s].EnabledByDefault = true |
There was a problem hiding this comment.
Should we allow specifying true/false so #7375 can be covered as well.
There was a problem hiding this comment.
I dislike the config in env.sample, but I have no better ideas.
d4x1
previously approved these changes
Apr 26, 2024
klesh
approved these changes
Apr 28, 2024
|
close #7375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduce the entities collected by default and implement a configuration that is convenient for users to collect
Does this close any open issues?
Related to #5920
Screenshots
github:
jira:
gitlab:
Other Information
Any other information that is important to this PR.