Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception on 204 when collecting jobs #5300

Merged
merged 2 commits into from
May 30, 2023

Conversation

CamilleTeruel
Copy link
Contributor

Summary

Fix error when collecting jobs of builds that failed because of bad azure-pipelines.yaml.

Does this close any open issues?

Closes #5083

@CamilleTeruel CamilleTeruel requested a review from hezyin May 26, 2023 15:08
@CamilleTeruel CamilleTeruel force-pushed the 5083_exception_on_204 branch 3 times, most recently from f4c26c0 to 7c52e91 Compare May 29, 2023 14:12
@CamilleTeruel CamilleTeruel self-assigned this May 29, 2023
Copy link
Contributor

@hezyin hezyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hezyin hezyin merged commit 45e7efb into apache:main May 30, 2023
7 of 8 checks passed
chenggui53 pushed a commit to chenggui53/incubator-devlake that referenced this pull request Jun 6, 2023
* fix: Do not raise APIException when status < 400

* fix: Let jobs endpoint handle 204 NO CONTENT status

---------

Co-authored-by: Camille Teruel <camille.teruel@meri.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Azure DevOps] Error when collecting some failed pipeline runs
2 participants