feat(gitextractor): add progress info when cloning git repos #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keon94
reviewed
Nov 30, 2023
| } | ||
| } | ||
|
|
||
| type testSubTaskContext struct{} |
There was a problem hiding this comment.
you should be able to just create a mock of SubTaskContext and just override the SetProgress method instead
There was a problem hiding this comment.
@keon94 Can you give me some tutorial on "create a mock of SubTaskConext"? I am not familiar with it.
abeizn
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
go mod tidy && go mod download, so mod file has changed.SetProgress.Does this close any open issues?
Closes None
Screenshots
Include any relevant screenshots here.
API Response
Debug log
All tasks are completed successfully
Other Information
Any other information that is important to this PR.