fix(configui): tagsLimit should be a number #6261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandesvitor
pushed a commit
to sandesvitor/incubator-devlake
that referenced
this pull request
Oct 19, 2023
abeizn
added a commit
that referenced
this pull request
Nov 24, 2023
* feat: Opsgenie plugin implementation * fix(lint): lint with gofmt * refactor(lint): removing unused config-ui files * feat(task): changed incident collector to accept incremental collection * fix(config-ui): adjust the params for bp add connection (#6241) * refactor: removed unused code (#6243) * refactor(config-ui): remove content about user info (#6245) * fix(azure): fix 400 error when cloing azure repos (#6246) * fix: normalize_bp_settings throws error (#6249) * fix: normalize_bp_settings throws error * fix: pg ci * fix: pg ci (#6252) * fix(gitlab): fix incremental deployment collector (#6254) * fix(gitlab): fix incremental deployment collector * fix(gitlab): rollback to full collector * refactor(gitlab): remove unused codes * fix(gitlab): collect deployment incrementally * fix: modify _tool_jira_issue_relationships primary key (#6253) * fix: modify _tool_jira_issue_relationships primary key * fix: ci lint * feat(pagerduty): search remote scope by keyword (#6255) * feat(pagerduty): search remote scope by keyword * feat(pagerduty): add `createdAt` field * refactor(impl): refactoring impl.go and service model * refactor(comment): removing comment from incident collector * feat(task): added GetCreated function * feat(zentao): check db url when testing connections (#6258) * feat(zentao): check db url when testing connections * fix(zentao): remove test codes * fix(zentao): remove test codes * fix(configui): tagsLimit should be a number (#6261) * fix(check): fixing lint in config-ui * refactor(newline): adding removed newline * fix(config-ui): removed old plugin type * refactor(config-ui): remove type inheritance from opsgenieconfig * style(config-ui): update icon with icon.svg --------- Co-authored-by: 青湛 <0x1304570@gmail.com> Co-authored-by: Klesh Wong <zhenmian.huang@merico.dev> Co-authored-by: Lynwee <linwei.hou@merico.dev> Co-authored-by: abeizn <zikuan.an@merico.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
tagsLimit should be a number https://github.com/apache/incubator-devlake/blob/main/backend/plugins/refdiff/models/refdiff_options.go#L34 , if it is a string, refdiff task will fail.
Does this close any open issues?
Closes N/A
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.