Change the type of duration_sec from int to float
#6465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeizn
reviewed
Nov 16, 2023
| @@ -99,14 +99,13 @@ func ConvertStages(taskCtx plugin.SubTaskContext) (err errors.Error) { | |||
| if body.Name == "" { | |||
| return nil, err | |||
| } | |||
| var durationMillis int | |||
| var durationMillis int64 | |||
There was a problem hiding this comment.
@abeizn it's used in https://github.com/apache/incubator-devlake/pull/6465/files/f5c07a15ba95e0bed72b4e38978541c806bb269b#diff-04993880854c505f74bc13205726cd68e47ed4a05ba170cdf2ca864abef43d4cL125 , I think keeping it int64 is proper.
abeizn
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
Fix #6136
Does this close any open issues?
Closes #6136
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.