fix(webhook): add migration script when webhooks have no API keys #6472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix-webhook-apikey
klesh
approved these changes
Nov 16, 2023
abeizn
pushed a commit
that referenced
this pull request
Nov 16, 2023
…ve no API keys to v0.20 (#6479)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
When running an old version of devlake, webhook be created without api keys, and if it's upgraded to version >= v0.19(webhook has a api key), user cannot regenerate webhooks' api keys.
This PR just creates a related api key for existing webhooks, so users can regenerate it.
To run migration scripts, user should open Config UI and trigger the migration.
Does this close any open issues?
Closes part of #6467
Screenshots
Include any relevant screenshots here.
update partially
Other Information
Any other information that is important to this PR.