Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: yarn library license issues #6483

Merged
merged 3 commits into from Nov 24, 2023
Merged

fix: yarn library license issues #6483

merged 3 commits into from Nov 24, 2023

Conversation

abeizn
Copy link
Contributor

@abeizn abeizn commented Nov 20, 2023

Summary

fix: yarn library license issues

Does this close any open issues?

Closes na

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

pjfanning
pjfanning reviewed Nov 20, 2023
View reviewed changes
config-ui/.yarn/releases/yarn-3.4.1.cjs
@@ -1,34 +1,6 @@
#!/usr/bin/env node
/* eslint-disable */
//prettier-ignore
/*!

This comment was marked as resolved.

Sign in to view

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you at least add a link for the LICENSE file but ideally you should list the licenses here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, the bsd license should be listed here just like the apache license is listed in other files

LICENSE Outdated
@@ -234,32 +234,24 @@ SOFTWARE.

--------------------------------------------------------------------------------

The following file is distributed under the BSD 2-Clause License:
The following file is distributed under the Licenses:

This comment was marked as resolved.

Sign in to view

pjfanning
pjfanning reviewed Nov 21, 2023
View reviewed changes
LICENSE
@@ -234,14 +234,11 @@ SOFTWARE.

--------------------------------------------------------------------------------

The following file is distributed under the BSD 2-Clause License:
The following file is distributed under different licenses:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should list them all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like they have listed them all, although perhaps not quite in the format I would have chosen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi justin, thank you very much for your question. Regarding the format you mentioned, I would like to ask you to clarify which format you are referring to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinmclean

@abeizn abeizn added bot/auto-cherry-pick-for-release-v0.19 auto cherry pick pr for release-v0.19 bot/auto-cherry-pick-for-release-v0.20 auto cherry pick pr for release-v0.20 labels Nov 24, 2023
@d4x1 d4x1 merged commit 1986653 into main Nov 24, 2023
10 checks passed
@d4x1 d4x1 deleted the fix-license-issues branch November 24, 2023 09:36
@abeizn abeizn added needs-cherrypick-v0.19 and removed bot/auto-cherry-pick-for-release-v0.19 auto cherry pick pr for release-v0.19 bot/auto-cherry-pick-for-release-v0.20 auto cherry pick pr for release-v0.20 labels Nov 24, 2023
github-actions bot pushed a commit that referenced this pull request Nov 24, 2023
@abeizn
fix: yarn library license issues (#6483)
ddc7150 
* fix: yarn library use license

* fix: typo

* fix: yarn software license issues
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
Merged
@github-actions GitHub Actions
Copy link

🤖 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Nov 24, 2023
abeizn added a commit that referenced this pull request Nov 24, 2023
@github-actions @abeizn
fix: yarn library license issues (#6483) (#6515)
bd548a2 
* fix: yarn library use license

* fix: typo

* fix: yarn software license issues

Co-authored-by: abeizn <zikuan.an@merico.dev>
github-actions bot pushed a commit that referenced this pull request Nov 24, 2023
@abeizn
fix: yarn library license issues (#6483)
74a6561 
* fix: yarn library use license

* fix: typo

* fix: yarn software license issues
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
Merged
@github-actions GitHub Actions
Copy link

🤖 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Nov 24, 2023
abeizn added a commit that referenced this pull request Nov 24, 2023
@github-actions @abeizn
fix: yarn library license issues (#6483) (#6516)
b314f86 
* fix: yarn library use license

* fix: typo

* fix: yarn software license issues

Co-authored-by: abeizn <zikuan.an@merico.dev>
@xiaomingzhang12 xiaomingzhang12 mentioned this pull request Dec 19, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmclean justinmclean justinmclean left review comments

@pjfanning pjfanning pjfanning left review comments

@d4x1 d4x1 d4x1 approved these changes

Assignees
No one assigned
Labels
bot/auto-cherry-pick-completed auto cherry pick completed needs-cherrypick-v0.20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abeizn @justinmclean @d4x1 @pjfanning