feat: allow deployment webhook to push deployments to multiple repos … #6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klesh
approved these changes
Nov 30, 2023
d4x1
reviewed
Nov 30, 2023
| if err != nil { | ||
| logger.Error(err, "create deployment commit") | ||
| return nil, err | ||
| duration := request.FinishedDate.Sub(*request.StartedDate).Seconds() |
There was a problem hiding this comment.
duration is float type now. So please use .Milliseconds(), and divide 1000, get the float64 duration.
| if request.DeploymentCommits == nil { | ||
| name = fmt.Sprintf(`deployment for %s`, request.CommitSha) | ||
| } else { | ||
| commit_sha_list := []string{} |
There was a problem hiding this comment.
why not name it with commitShaList?
| } else { | ||
| commit_sha_list := []string{} | ||
| for _, commit := range request.DeploymentCommits { | ||
| commit_sha_list = append(commit_sha_list, commit.CommitSha) |
| } | ||
| } else { | ||
| for _, commit := range request.DeploymentCommits { | ||
| urlHash16 := fmt.Sprintf("%x", md5.Sum([]byte(commit.RepoUrl)))[:16] |
There was a problem hiding this comment.
I think it is duplicated code, and can be wrapped to a function.
There was a problem hiding this comment.
no, this is in the loop
| // start_time and end_time is more readable for users, | ||
| // StartedDate and FinishedDate is same as columns in db. | ||
| // So they all keep. | ||
| CreatedDate *time.Time `mapstructure:"create_time"` | ||
| StartedDate *time.Time `mapstructure:"start_time" validate:"required"` | ||
| FinishedDate *time.Time `mapstructure:"end_time"` | ||
| RepoUrl string `mapstructure:"repo_url"` | ||
| Environment string `validate:"omitempty,oneof=PRODUCTION STAGING TESTING DEVELOPMENT"` |
There was a problem hiding this comment.
why doesn't this field have mapstructure?
There was a problem hiding this comment.
This will not change the name, it will be resolved into environment
|
all fixed by other pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat: allow deployment webhook to push deployments to multiple repos in one request
[BE] Support the new payload
[BE] Add commit_msg to table cicd_deployment_commits
[FE] Update webhook deployment example
Does this close any open issues?
Related to #6262
Screenshots
Other Information
Any other information that is important to this PR.