Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): upgrade gorm to v1.25.5 #6633

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(db): upgrade gorm to v1.25.5 #6633

merged 1 commit into from
Dec 15, 2023

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Dec 15, 2023

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. Upgrade gorm to v1.25.5, try to fix potential panic, more detail: panic: runtime error: invalid memory address or nil pointer dereference go-gorm/gorm#6397
  2. Return directly when getDbConnection failed

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.
The panic log looks like:
image

@d4x1 d4x1 added this to the v0.21 milestone Dec 15, 2023
@d4x1 d4x1 requested review from klesh and abeizn December 15, 2023 02:07
@d4x1 d4x1 self-assigned this Dec 15, 2023
@klesh klesh merged commit 071806c into apache:main Dec 15, 2023
12 checks passed
@d4x1 d4x1 mentioned this pull request Dec 15, 2023
Merged
@d4x1 d4x1 added the cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. label Dec 15, 2023
@d4x1 d4x1 mentioned this pull request Dec 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klesh klesh klesh approved these changes

@abeizn abeizn Awaiting requested review from abeizn

Assignees

@d4x1 d4x1

Labels
cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. needs-cherrypick-v0.20 pr-type/bug-fix This PR fixes a bug
Projects
None yet
Milestone
v0.21
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d4x1 @klesh