Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch): fix wrong use of db.Fetch #6666

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Dec 19, 2023

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
In db.Fetch(cursor, dst), dst should be a local variable that is defined in a loop. Otherwise, it will store data from the previous epoch which is unexpected.

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

Copy link
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abeizn abeizn merged commit 49f276f into apache:main Dec 19, 2023
10 checks passed
@d4x1 d4x1 deleted the lake-lw-update-use-of-db-fetch branch December 19, 2023 08:03
@d4x1 d4x1 added this to the v0.21 milestone Dec 19, 2023
@d4x1 d4x1 added the cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. label Dec 19, 2023
@abeizn abeizn added the component/framework This issue or PR relates to the framework label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. component/framework This issue or PR relates to the framework needs-cherrypick-v0.20 pr-type/bug-fix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants