Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): secret key and token are not empty now #6704

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Dec 29, 2023

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. Password should be sanitized to empty string.
  2. Token and SecretKeys should be kept some identifiers.
    This PR just check all the sanitizer and fix it if necessary.

Does this close any open issues?

Parts of #5643

Screenshots

Include any relevant screenshots here.

Circle CI

image

GitLab

image

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 requested review from abeizn and klesh December 29, 2023 02:59
@abeizn abeizn merged commit 515bb8b into apache:main Dec 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants