fix and refactor: db migration logging logic #7188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeizn
previously approved these changes
Mar 18, 2024
klesh
force-pushed
the
kw-migration-logging
branch
from
aedc504
to
e450a4c
Compare
abeizn
approved these changes
Mar 18, 2024
abeizn
pushed a commit
that referenced
this pull request
Mar 29, 2024
* refactor: db migration logging logic * fix: linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
previously, the message "Db migration confirmation needed" would always be printed.
This PR fixes the problem and refactors the code to improve the readibility.