Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ready and health probes #7195

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat: add ready and health probes #7195

merged 1 commit into from
Mar 20, 2024

Conversation

klesh
Copy link
Contributor

@klesh klesh commented Mar 20, 2024

Summary

Added the following probing endpoints:

  1. /ready: returns 200 OK when system is fully initialized, or 503 Service Unavailable otherwise
  2. /health: returns 200 OK when system is health, or 500 Server Insternal Error when loading pipelines from the database

ZhangNing10
ZhangNing10 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@ZhangNing10 ZhangNing10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhangNing10 ZhangNing10 merged commit b266ff3 into main Mar 20, 2024
10 checks passed
@ZhangNing10 ZhangNing10 deleted the kw-probes branch March 20, 2024 10:19
abeizn pushed a commit that referenced this pull request Mar 29, 2024
@klesh @abeizn
feat: add ready and health probes (#7195)
ec74182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhangNing10 ZhangNing10 ZhangNing10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@klesh @ZhangNing10