fix: populate missing RepoUrl in CiCDPipelineCommit #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mr-ks Hi, this seems to be a legit fix to me, would you like to rebase it so I can merge it? Thanks. |
dosubot
bot
added
the
size:S
|
@klesh, done. Thanks for the reminder |
klesh
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
enrichPrevSuccessDeploymentCommitstask of the dora plugin relies oncicd_deployment_commits.repo_urlto fetch all successful deployments in a given project. Deployments without a specifiedrepo_urlwill not be included in the subsequent calculation steps. Which will lead to problems in the form of #7193.This PR populates the missing
repo_urlcolumn by joining_tool_azuredevops_go_buildsand_tool_azuredevops_go_reposin theconvertApiBuildstask of the Azure DevOps Go plugin.Does this close any open issues?
Not sure if this closes #7193 but is definitely related