fix(db): alter commit columns to binary type #7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duhow
changed the title
klesh
approved these changes
Mar 26, 2024
|
@klesh I've updated the commit title to match the lint expected, can you run the workflow again? |
|
@duhow Thanks for your contribution. 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migration schema for MySQL.
commits.messageis nowCHARACTER SET binary,commit_files.file_pathis nowVARBINARY.The reason is to support ASCII-extended characters in both columns.
file_pathis slow, about 3 minutes for ~1.4 million records.Does this close any open issues?
Fixes #7203
Fixes #7198