feat: collect and extract jenkins jobs from multibranch pipelines #7213
Conversation
gustavobini
force-pushed
the
jenkins-multibranch
branch
from
f34c28c
to
a50b73e
Compare
|
Hi, @gustavobini , Sorry, I have been working on some performance optimization recently, may I come back to you maybe next week? |
yes that's perfectly fine! |
| ConnectionId: connection.ID, | ||
| FullName: jenkinsJob.FullName, | ||
| ConnectionId: connection.ID, | ||
| ConnectionEndpoint: connection.Endpoint, |
There was a problem hiding this comment.
Can we store the extra information in the _tool_jenkins_jobs table instead of passing it around?
There was a problem hiding this comment.
The class is used at the tasks as the input between multi-branch and other jobs, so it needs to be available before. The ConnectionEndpoint cannot be stored in the _tool_jenkins_jobs db, as that will break the plugin in case the connection endpoint changes.
There was a problem hiding this comment.
I see.
How about that we load the information during the PrepareTaskData phase?
By doing so, we could rerun the plan even after the connection endpoint changed without the need to update every related blueprints, especially for recurring Advanced Blueprint
There was a problem hiding this comment.
I get what you mean. I'll do that
There was a problem hiding this comment.
@klesh I've moved the properties. I'm not happy with how it is, but I think it's the simplest. All the job names and path validations and assignments being done around make me hesitant to do more. I actually wanna get that refactored at some point if possible.
There was a problem hiding this comment.
Thanks for the update.
Would you like me to merge it now so you may take time for the refactor?
There was a problem hiding this comment.
@klesh yes please! and thank you
There was a problem hiding this comment.
I can't tell what's wrong with the lint-commit-message error 🤔
|
lint commit message checks if all commit messages of the PR fit https://www.conventionalcommits.org/en/v1.0.0/, it is optional. |
gustavobini
force-pushed
the
jenkins-multibranch
branch
from
0754215
to
9196511
Compare
@klesh done! |
Summary
Collects and extracts job, build, and stages data from multi-branch Jenkins pipelines.
Does this close any open issues?
#5633