fix: make FinishTime optional for unfinished builds #7401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds in progress do not have a finish time set, causing an internal server error when the plugin attempts to write "0000-00-00" into the database. To address this issue, the FinishTime field of the Build API response struct is changed from `time.Time` to a pointer value `*time.Time`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds in progress do not have a finish time set, causing an internal server error when the plugin attempts to write "0000-00-00" into the database. To address this issue, the
FinishTimefield of the Build API response struct is changed fromtime.Timeto a pointer value*time.Time.The build duration is calculated only when
FinishTimeis set, otherwise it is set to0.0.Does this close any open issues?
Closes #7369