Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move deployment converter to github_graphql plugin #7486

Merged
merged 2 commits into from
May 17, 2024

Conversation

klesh
Copy link
Contributor

@klesh klesh commented May 17, 2024

Summary

Move deployment converter from the github plugin to the github_graphql plugin since deployment collection is implemented only in the latter, better to keep them in one place.

Screenshots

Tested
image

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. component/plugins This issue or PR relates to plugins improvement pr-type/refactor This PR refactors existing features labels May 17, 2024
d4x1
d4x1 previously approved these changes May 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 17, 2024
@d4x1 d4x1 merged commit e950d62 into main May 17, 2024
10 checks passed
@d4x1 d4x1 deleted the kw-refactor-move-deployment-converter-to-github_graphql branch May 17, 2024 09:40
d4x1 pushed a commit that referenced this pull request May 23, 2024
* refactor: move deployment converter to github_graphql plugin

* fix: e2e test for deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugins This issue or PR relates to plugins improvement lgtm This PR has been approved by a maintainer pr-type/refactor This PR refactors existing features size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants