-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(github): use different graphql path in enterprise version #7541
Conversation
endpoint.Path = "/graphql" // see https://docs.github.com/en/graphql/guides/forming-calls-with-graphql | ||
if endpoint.Hostname() != "api.github.com" { | ||
// see https://docs.github.com/en/enterprise-server@3.11/graphql/guides/forming-calls-with-graphql | ||
endpoint.Path = "/api/graphql" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
I just want to make sure that all On-premise GitHub deployments are Enterprise Edition? Or in other words, do they all follow this URL-forming pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @klesh ,
Is the question directed to me or you mean you are checking it in the background?
From my side it is hard to know if all on-premise instances use this pattern as I only know the instance we use. Besides from that I double checked with Renovate source code and they also have custom handling for Github Enterprise, see https://github.com/renovatebot/renovate/blob/main/lib/util/github/graphql/datasource-fetcher.ts#L85.
So I would consider it safe to assume that this is the standard for on-premise instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the information, very informative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pr-type/bug-fix
,pr-type/feature-development
, etc.Summary
Does this close any open issues?
Other Information