feat: add jira_trace plugin to jira bp #7569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
dosubot
bot
added
size:M
dosubot
bot
added
size:L
klesh
reviewed
Jun 5, 2024
|
|
||
| db := taskCtx.GetDal() | ||
| inserter := helper.NewBatchSaveDivider(taskCtx, utils.BATCH_SIZE, rawTableIssueChangelogs, boardId) | ||
| inserter := helper.NewBatchSaveDivider(taskCtx, utils.BATCH_SIZE, rawTableIssueChangelogs, scopeIds[0]) |
There was a problem hiding this comment.
This doesn't seem correct. It looks like all records will be marked as if they belong to the first scope while not.
| BoardId uint64 `json:"boardId"` // 68 | ||
| LakeBoardId string `json:"lakeBoardId"` // jira:JiraBoard:1:68 | ||
| Plugin string `json:"plugin"` // jira | ||
| ScopeIds []string `json:"scopeId"` // 68 |
There was a problem hiding this comment.
json should be renamed to scopeIds as well
klesh
previously approved these changes
Jun 6, 2024
klesh
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat: add jira_trace plugin to jira bp
Does this close any open issues?
Closes na
Screenshots
Other Information
Any other information that is important to this PR.