Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if no data, the On-time Delivery chart should show no data #7576

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

abeizn
Copy link
Contributor

@abeizn abeizn commented Jun 5, 2024

Summary

fix: if no data, the On-time Delivery chart should show no data

Does this close any open issues?

Closes #7398

Screenshots

image

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/ext This issue or PR relates to external components, such as Grafana pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident labels Jun 5, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 5, 2024
@klesh klesh merged commit c959ed0 into main Jun 5, 2024
10 checks passed
@klesh klesh deleted the fix#7398 branch June 5, 2024 14:13
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
* fix: if no data, the On-time Delivery chart should show no data

* fix: calculate cycle time when deploy time is nil

* fix: e2e
Copy link

github-actions bot commented Jun 7, 2024

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Jun 7, 2024
abeizn added a commit that referenced this pull request Jun 7, 2024
… (#7589)

* fix: if no data, the On-time Delivery chart should show no data

* fix: calculate cycle time when deploy time is nil

* fix: e2e

Co-authored-by: abeizn <zikuan.an@merico.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/ext This issue or PR relates to external components, such as Grafana lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Grafana] Some KPIs show 0 or 100 if data is incomplete
2 participants