Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bitbucket remote api swallows errors sliently #7583

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

klesh
Copy link
Contributor

@klesh klesh commented Jun 6, 2024

The remote api ignores errors returned by Bitbucket API and outputs an empty children in the response which is really bad.

This PR fixes the problem, now users should be able to see what went wrong:

image

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins type/bug This issue is a bug labels Jun 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 6, 2024
@abeizn abeizn merged commit 7812288 into main Jun 6, 2024
14 checks passed
@abeizn abeizn deleted the kw-bitbucket-remoteapi-silent-err branch June 6, 2024 07:51
Copy link

github-actions bot commented Jun 7, 2024

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Jun 7, 2024
abeizn pushed a commit that referenced this pull request Jun 7, 2024
Co-authored-by: Klesh Wong <zhenmian.huang@merico.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 size:XS This PR changes 0-9 lines, ignoring generated files. type/bug This issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants