Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): sanitize gitextractor plugin options correctly #7622

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Jun 14, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

Does this close any open issues?

Closes #7597

Screenshots

Include any relevant screenshots here.

Get a project detail

image

Get a blueprint detail

image

Trigger a blueprint

image

List all projects

image

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 14, 2024
@d4x1 d4x1 self-assigned this Jun 14, 2024
@dosubot dosubot bot added the component/framework This issue or PR relates to the framework label Jun 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 14, 2024
@abeizn abeizn merged commit 44f3dea into main Jun 14, 2024
10 checks passed
@abeizn abeizn deleted the dev0614-2 branch June 14, 2024 05:43
github-actions bot pushed a commit that referenced this pull request Jun 14, 2024
* fix(framework): sanitize gitextractor plugin options correctly

* fix(test): fix panic when running CI
Copy link

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Jun 14, 2024
d4x1 added a commit that referenced this pull request Jun 14, 2024
#7623)

* fix(framework): sanitize gitextractor plugin options correctly

* fix(test): fix panic when running CI

Co-authored-by: Lynwee <linwei.hou@merico.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/framework This issue or PR relates to the framework lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][API] GET /projects exposes GitLab token in the gitextractor plugin
2 participants