[Feature-2585][server] Support ssh command #3283
Conversation
Only linux support SSH command
|
Hi, Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~ |
|
OK, Got it
…------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 下午3:20
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] Merge support ssh command (#3283)
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
peilongwu
changed the title
|
I already modify the pr title and comment.
…------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 下午3:20
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] Merge support ssh command (#3283)
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
|
||
| @RunWith(SpringRunner.class) | ||
| @SpringBootTest(classes = ApiApplicationServer.class) | ||
| public class DataSourceService2Test { |
There was a problem hiding this comment.
Hi,
Please add this test to root pom if you introduce this test case.
|
Hi,
If you have any question or suggestion, welcome to put forward.
|
|
I add this test in root pom before.
I forgot to add this test when I solved the conflicts in this time.
…------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上7:55
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
@yangyichao-mango commented on this pull request.
In dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceService2Test.java:
> +import org.apache.dolphinscheduler.common.enums.UserType; +import org.apache.dolphinscheduler.dao.entity.User; +import org.junit.Assert; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.context.SpringBootTest; +import org.springframework.test.context.junit4.SpringRunner; + +import java.util.Map; + +@RunWith(SpringRunner.class) +@SpringBootTest(classes = ApiApplicationServer.class) +public class DataSourceService2Test {
Hi,
Why introduce this test case without adding this test to root pom?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
…------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上10:42
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
We can not include and use jsch officially in DolphinScheduler because of the licenses.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
…------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上10:50
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Hi,
I have checked the license of `jsch`, it is suitable for DolphinScheduler~
…------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月24日(星期五) 上午10:02
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "Yichao Yang"<1048262223@qq.com>;"Mention"<mention@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------&nbsp;原始邮件&nbsp;------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com&gt;;
发送时间:&nbsp;2020年7月23日(星期四) 晚上10:50
收件人:&nbsp;"apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com&gt;;
抄送:&nbsp;"裴龙武"<peilongwu@qq.com&gt;;"Author"<author@noreply.github.com&gt;;
主题:&nbsp;Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I do not have a good idea to add many remote servers. If we can not add these remote servers to data source, we must develop a new feature to manage remote server.
…------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上11:09
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
I switch to your branch and check the feature.
Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1]
If you have any question or suggestion, welcome to put forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
OK, it's very good.
…------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月24日(星期五) 上午10:04
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
I have checked the license of `jsch`, it is suitable for DolphinScheduler~
------------------&nbsp;原始邮件&nbsp;------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com&gt;;
发送时间:&nbsp;2020年7月24日(星期五) 上午10:02
收件人:&nbsp;"apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com&gt;;
抄送:&nbsp;"Yichao Yang"<1048262223@qq.com&gt;;"Mention"<mention@noreply.github.com&gt;;
主题:&nbsp;Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------&amp;nbsp;原始邮件&amp;nbsp;------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com&amp;gt;;
发送时间:&amp;nbsp;2020年7月23日(星期四) 晚上10:50
收件人:&amp;nbsp;"apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com&amp;gt;;
抄送:&amp;nbsp;"裴龙武"<peilongwu@qq.com&amp;gt;;"Author"<author@noreply.github.com&amp;gt;;
主题:&amp;nbsp;Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
It has a lot of cases to use many remote serves to execute some shell commands. So I think that we must to design a good method to support this feature.
I want to add a new table to manage the remote servers， but many committers feel that this change is too big. They think we can manage remote servers like data sources. So I develop this feature like this.
…------------------ 原始邮件 ------------------
发件人: "apache/incubator-dolphinscheduler" <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上11:09
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283)
Hi,
I switch to your branch and check the feature.
Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1]
If you have any question or suggestion, welcome to put forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I got it. |
|
Hi,
|
|
@peilongwu , supporting ssh task will be an important feature, and could you add password free to ssh task? by the way, please solve the conflicting files, thx
|
OK, I will perfect this feature in the next time. I was changing job recently. Now I work in a new company and I have times to finish this feature. |
|
there are some conflict files need to be sovled, please solve it locally, then I will merge into dev, thx |
davidzollo
added
the
Waiting for user feedback
|
no update. |
What is the purpose of the pull request
Support execute command on remote server. Only support linux.
Brief change log