add feature : query top n success process instance order by running duration #3315

RedemptionC · 2020-07-27T02:55:19Z

What is the purpose of the pull request

close (#3191)

Brief change log

add function in ProcessInstanceController.java , ProcessInstanceService.java , ProcessInstanceMapper.java
add some test in ProcessInstanceServiceTest.java , ProcessInstanceMapperTest.java
add some constant/status in Status.java , Constants.java
add some sql in ProcessInstanceMapper.xml

Verify this pull request

Manually verified the change by testing locally.

…uration

CalvinKirs · 2020-07-27T03:47:14Z

Hi, have you encountered any problems? You can add me to WeChat to communicate. My WeChat is Kris_Evil

CalvinKirs · 2020-07-27T12:22:24Z

...-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessInstanceController.java

+                                                         @RequestParam(value = "endTime",required = true) String endTime
+
+    ){
+        projectName=projectName.replaceAll("[\n|\r\t]", "_");


You should improve the handleEscapes method, this is a historical problem. like this:return inputString.replace("%", "////%").replaceAll("[\n|\r|\t]", "_");

improve handleEscape method in ParameterUtils.java

yangyichao-mango · 2020-07-29T11:45:46Z

Good job,
I think this sonar checker can be removed. @dailidong , Please help to confirm.

yangyichao-mango · 2020-07-29T11:48:52Z

...-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessInstanceController.java

@@ -204,6 +205,29 @@ public Result queryProcessInstanceById(@ApiIgnore @RequestAttribute(value = Cons
        return returnDataList(result);
    }

+    @ApiOperation(value = "queryTopNLongestRunningProcessInstance", notes = "QUERY_TOPN_LONGEST_RUNNING_PROCESS_INSTANCE_NOTES")


Hi,
It will be better to add the java docs like[1] here. can you do it?
[1]

ok , I will do it in next commit

yangyichao-mango · 2020-07-29T11:51:35Z

...eduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java

+            putMsg(result, Status.DATA_IS_NULL, Constants.END_TIME);
+            return result;
+        }
+        Date end=DateUtils.stringToDate(endTime);


Suggested change

Date end=DateUtils.stringToDate(endTime);

Date end = DateUtils.stringToDate(endTime);

yangyichao-mango · 2020-07-29T11:51:51Z

...eduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java

+            putMsg(result, Status.DATA_IS_NULL, Constants.START_TIME);
+            return result;
+        }
+        Date start=DateUtils.stringToDate(startTime);


Suggested change

Date start=DateUtils.stringToDate(startTime);

Date start = DateUtils.stringToDate(startTime);

yangyichao-mango · 2020-07-29T11:52:08Z

...eduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java

+     * @param endTime
+     * @return
+     */
+    public Map<String, Object> queryTopNLongestRunningProcessInstance(User loginUser,String projectName,int size, String startTime, String endTime) {


Suggested change

public Map<String, Object> queryTopNLongestRunningProcessInstance(User loginUser,String projectName,int size, String startTime, String endTime) {

public Map<String, Object> queryTopNLongestRunningProcessInstance(User loginUser, String projectName, int size, String startTime, String endTime) {

yangyichao-mango · 2020-07-29T11:52:40Z

dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java

+    public static final String START_TIME="start time";
+    public static final String END_TIME="end time";


Suggested change

public static final String START_TIME="start time";

public static final String END_TIME="end time";

public static final String START_TIME = "start time";

public static final String END_TIME = "end time";

yangyichao-mango · 2020-07-29T11:53:38Z

...er-api/src/test/java/org/apache/dolphinscheduler/api/service/ProcessInstanceServiceTest.java

@@ -147,6 +147,40 @@ public void testQueryProcessInstanceList() {

    }

+    @Test
+    public void testQueryTopNLongestRunningProcessInstance(){


Suggested change

public void testQueryTopNLongestRunningProcessInstance(){

public void testQueryTopNLongestRunningProcessInstance() {

yangyichao-mango · 2020-07-29T11:53:46Z

...eduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java

+            return result;
+        }
+        Date end=DateUtils.stringToDate(endTime);
+        if(start == null || end == null){


Suggested change

if(start == null || end == null){

if(start == null || end == null) {

yangyichao-mango · 2020-07-29T11:54:09Z

...-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessInstanceController.java

+                                                         @RequestParam(value = "startTime",required = true) String startTime,
+                                                         @RequestParam(value = "endTime",required = true) String endTime
+
+    ){


Suggested change

){

) {

yangyichao-mango

Please format this code. Thx a lot~

CalvinKirs · 2020-07-29T12:03:23Z

In fact, the replacement of the CRLF string has been completed here, and I don't understand why sonar still reports this error. On 07/29/2020 19:46，Yichao Yang<notifications@github.com> wrote： Good job, I think this sonar checker can be removed. @dailidong , Please help to confirm. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

…duler into dev

sonarcloud · 2020-07-29T12:35:53Z

SonarCloud Quality Gate failed.

0 Bugs
1 Vulnerability (and 0 Security Hotspots to review)
0 Code Smells

57.1% Coverage
0.0% Duplication

nauu

LGTM

davidzollo · 2020-07-30T10:37:40Z

In fact, the replacement of the CRLF string has been completed here, and I don't understand why sonar still reports this error. On 07/29/2020 19:46，Yichao Yangnotifications@github.com wrote： Good job, I think this sonar checker can be removed. @dailidong , Please help to confirm. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

this check could be ignore sometimes

davidzollo

+1
good job

davidzollo · 2020-07-30T10:39:23Z

close #3191

RedemptionC added 2 commits July 27, 2020 10:50

add feature : query top n success process instance order by running d…

6d3c437

…uration

add feature : add params check

05cd5f5

RedemptionC added 3 commits July 27, 2020 18:39

add feature : remove code smell

8970b54

add feature : remove code smell

fcb6999

add feature : add param check

333add1

CalvinKirs reviewed Jul 27, 2020

View reviewed changes

add feature : add param check

a5d0557

improve handleEscape method in ParameterUtils.java

yangyichao-mango reviewed Jul 29, 2020

View reviewed changes

yangyichao-mango approved these changes Jul 29, 2020

View reviewed changes

yangyichao-mango reviewed Jul 29, 2020

View reviewed changes

yangyichao-mango suggested changes Jul 29, 2020

View reviewed changes

RedemptionC added 2 commits July 29, 2020 20:23

top n : add java doc and format code

372b83b

Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…

135ffe4

…duler into dev

nauu reviewed Jul 29, 2020

View reviewed changes

davidzollo approved these changes Jul 30, 2020

View reviewed changes

davidzollo merged commit 0c5754c into apache:dev Jul 30, 2020

davidzollo mentioned this pull request Jul 30, 2020

[Feature] add query top n process instance order by running duration #3191

Closed

davidzollo added this to the 1.4.0 milestone Jul 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add feature : query top n success process instance order by running duration #3315

add feature : query top n success process instance order by running duration #3315

RedemptionC commented Jul 27, 2020

CalvinKirs commented Jul 27, 2020

CalvinKirs Jul 27, 2020

yangyichao-mango commented Jul 29, 2020

yangyichao-mango Jul 29, 2020

RedemptionC Jul 29, 2020

yangyichao-mango Jul 29, 2020

yangyichao-mango Jul 29, 2020

yangyichao-mango Jul 29, 2020

yangyichao-mango Jul 29, 2020

yangyichao-mango Jul 29, 2020

yangyichao-mango Jul 29, 2020

yangyichao-mango Jul 29, 2020

yangyichao-mango left a comment

CalvinKirs commented Jul 29, 2020 via email

sonarcloud bot commented Jul 29, 2020

nauu left a comment

davidzollo commented Jul 30, 2020 •

edited

davidzollo left a comment

davidzollo commented Jul 30, 2020

	Date end=DateUtils.stringToDate(endTime);
	Date end = DateUtils.stringToDate(endTime);

	Date start=DateUtils.stringToDate(startTime);
	Date start = DateUtils.stringToDate(startTime);

	public Map<String, Object> queryTopNLongestRunningProcessInstance(User loginUser,String projectName,int size, String startTime, String endTime) {
	public Map<String, Object> queryTopNLongestRunningProcessInstance(User loginUser, String projectName, int size, String startTime, String endTime) {

		public static final String START_TIME="start time";
		public static final String END_TIME="end time";

	public void testQueryTopNLongestRunningProcessInstance(){
	public void testQueryTopNLongestRunningProcessInstance() {

	if(start == null \|\| end == null){
	if(start == null \|\| end == null) {

add feature : query top n success process instance order by running duration #3315

add feature : query top n success process instance order by running duration #3315

Conversation

RedemptionC commented Jul 27, 2020

What is the purpose of the pull request

Brief change log

Verify this pull request

CalvinKirs commented Jul 27, 2020

Choose a reason for hiding this comment

yangyichao-mango commented Jul 29, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yangyichao-mango left a comment

Choose a reason for hiding this comment

CalvinKirs commented Jul 29, 2020 via email

sonarcloud bot commented Jul 29, 2020

nauu left a comment

Choose a reason for hiding this comment

davidzollo commented Jul 30, 2020 • edited

davidzollo left a comment

Choose a reason for hiding this comment

davidzollo commented Jul 30, 2020

davidzollo commented Jul 30, 2020 •

edited