Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Change http to https #11

Merged
merged 1 commit into from Mar 6, 2022
Merged

Docs: Change http to https #11

merged 1 commit into from Mar 6, 2022

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Mar 5, 2022

Proposed changes

Issue Number: close #xxx

Problem Summary:

A minor PR, change links in README from http to https

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@pan3793
Copy link
Member Author

pan3793 commented Mar 5, 2022

Hi @morningman, sorry for asking questions in unrelated PR comments since the issue channel is not open in this project.

I find the project actually use Apache Maven as build system, but the maven root folder is a sub dir instead of root dir of the repo, do you have a plan to add other things not managed by maven to this repo?

Another question is the sub dir name is spark-doris-connector, but you define the <artifactId>doris-spark-connector</artifactId> in pom.xml, I think it's a little bit confusing.

@morningman
Copy link
Contributor

Hi @pan3793 , thanks for your contribution.

since the issue channel is not open in this project.

I didn't notice that the issue feature is disabled. I will enable it later.

I find the project actually use Apache Maven as build system, but the maven root folder is a sub dir instead of root dir of the repo, do you have a plan to add other things not managed by maven to this repo?

Yes, there may be some other tools not managed by manve.
Because we've just moved this submodule from the Doris main repo.
And before everything settle down, I prefer to use a single dir to save the source code of the connector along.

Another question is the sub dir name is spark-doris-connector, but you define the <artifactId>doris-spark-connector</artifactId> in pom.xml, I think it's a little bit confusing.

Indeed, I will change it later.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hf200012 hf200012 merged commit 869cbcc into apache:master Mar 6, 2022
@pan3793 pan3793 deleted the https branch March 13, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants