Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support segment zone map #1931

Merged
merged 4 commits into from
Oct 13, 2019
Merged

Support segment zone map #1931

merged 4 commits into from
Oct 13, 2019

Conversation

liutang123
Copy link
Contributor

#1860 Support segment zone map and key range.

@liutang123
Copy link
Contributor Author

cc @gaodayue support segment zone map.

@liutang123 liutang123 closed this Oct 8, 2019
@liutang123 liutang123 reopened this Oct 8, 2019
@liutang123 liutang123 closed this Oct 8, 2019
@liutang123 liutang123 reopened this Oct 8, 2019
@liutang123 liutang123 closed this Oct 8, 2019
@liutang123 liutang123 reopened this Oct 8, 2019
gensrc/proto/segment_v2.proto Outdated Show resolved Hide resolved
gensrc/proto/segment_v2.proto Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/segment.cpp Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/segment_iterator.h Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/column_zone_map.cpp Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/column_zone_map.cpp Outdated Show resolved Hide resolved
@gaodayue
Copy link
Contributor

gaodayue commented Oct 8, 2019

Also note that BetaRowset, Segment, and ColumnReader should be thread safe but the current implementation is not. However I think this should be fixed in a separate PR.

be/src/olap/rowset/segment_v2/segment.cpp Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/column_zone_map.cpp Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/column_zone_map.cpp Outdated Show resolved Hide resolved
be/src/olap/rowset/segment_v2/segment.cpp Outdated Show resolved Hide resolved
if (!c_meta.has_zone_map()) {
continue;
}
ZoneMapPB c_zone_map = c_meta.zone_map();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ZoneMapPB c_zone_map = c_meta.zone_map();
auto& c_zone_map = c_meta.zone_map();

@imay imay closed this Oct 12, 2019
@imay imay reopened this Oct 12, 2019
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay closed this Oct 13, 2019
@imay imay reopened this Oct 13, 2019
@imay imay merged commit d68b1b2 into apache:master Oct 13, 2019
xy720 pushed a commit to xy720/doris that referenced this pull request Oct 18, 2019
wuyunfeng pushed a commit to wuyunfeng/incubator-doris that referenced this pull request Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants